DM-55233: Add prompt_source functors - #1327
Merged
Merged
Conversation
ctslater
force-pushed
the
tickets/DM-55233
branch
from
August 17, 2026 04:38
7038602 to
560c980
Compare
jrmullaney
reviewed
Aug 18, 2026
jrmullaney
left a comment
jrmullaney
left a comment
Contributor
There was a problem hiding this comment.
Just a very small suggestion.
|
|
||
| # Run the real splitPromptSource step to check the final set of columns | ||
| splitConfig = SplitPrimaryTask.ConfigClass() | ||
| splitConfig.discard_primary_columns = ["sky_source"] |
Contributor
There was a problem hiding this comment.
Maybe add a comment to explain why you need to discard sky_source.
Member
There was a problem hiding this comment.
Sure; added a bit more description to the comment.
jrmullaney
approved these changes
Aug 18, 2026
ctslater
force-pushed
the
tickets/DM-55233
branch
from
August 19, 2026 21:17
560c980 to
87dcbfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.