lunatik: promote pushoptinteger to a shared helper - #736
Open
lneto wants to merge 1 commit into
Open
Conversation
luaskb defined its own pushoptinteger; move it to lunatik.h as lunatik_pushoptinteger so any module can push an optional integer (the value, or nil) through one helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
lneto
force-pushed
the
claude_pushoptinteger
branch
from
August 20, 2026 13:03
627d6a2 to
f42ef10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luaskbdefined its ownpushoptinteger— a generic "push an integer, or nil" Lua-stack helper with nothing skb-specific about it. Move it tolunatik.haslunatik_pushoptinteger, alongside the other push helpers (lunatik_pushstring), so it is shared rather than re-defined per module;luaskb'sifindex,vlan, andconnmarknow use it.No behavior change — the expansion is the same (the macro arguments are parenthesized).
connmarkexercises the macro on both branches (the value and thenilwhen no conntrack is associated); the skb suite covers it, 3/3.