Skip to content

🧹 Janitor: Refactor test server setup in index_test.go to remove duplication - #200

Merged
lucasew merged 1 commit into
masterfrom
janitor-refactor-test-server-9715673587155251802
Jul 28, 2026
Merged

🧹 Janitor: Refactor test server setup in index_test.go to remove duplication#200
lucasew merged 1 commit into
masterfrom
janitor-refactor-test-server-9715673587155251802

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Assumptions

  • The setupTestServer helper is the intended way to spin up the HTTP test servers in api/index_test.go.
  • Other tests should pass http.StatusOK to retain their existing behavior.

Alternatives Not Chosen

  • Creating a separate helper specifically for non-200 responses, to keep the API minimal.
  • Extracting test cases into table-driven tests for tests with unique logic.

How To Pivot

  • If a test requires specific headers or body checks, setupTestServer can be extended with a configuration struct instead of multiple arguments.

Next Knobs

  • TestFetchAndParseRejectsOversizedBody could check the specific error returned to ensure it is due to body size constraints.
  • Refactor the hardcoded strings into global constants (e.g. standard mock bodies).

Optional follow-ups

  • Check other tests for redundant server spin-ups.
  • Centralize mock clients into a dedicated mock_test.go file for broader reusability.

PR created automatically by Jules for task 9715673587155251802 started by @lucasew

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
articleparser Error Error Jul 28, 2026 10:03am

@lucasew
lucasew marked this pull request as ready for review July 28, 2026 13:44
@lucasew
lucasew merged commit 2cb663c into master Jul 28, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant