[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown - #288
[WRONG BRANCH] fix(lab): ensure manual Lab runs are cancellable during shutdown#288luvs01 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
/api/lab/automation/runexecutions from continuing pastdrainAndShutdownwhen Lab was never activated, by ensuring manual runs register a shutdown hook so they are cancelled like other Lab activities.Description
src/lab/automation/orchestrator.tsusingregisterOptionalShutdownHook(...)and detach it in afinallyblock so the hook cannot leak after completion.tests/lab-automation-review-regressions.test.tsthat starts a manual run, releases the activation lease, invokesrunOptionalShutdownHooks(), and asserts the manual run is cancelled.Testing
git diff --checkand created the fix commit (fix(lab): cancel manual runs during shutdown).bun run typecheck(local run) which completed without type errors for the edited modules.bun test tests/lab-automation-review-regressions.test.ts, which failed during module load with a Bun/runtimenode:zlibexport incompatibility (zstdDecompressSync) unrelated to this change; the failure prevented the full focused-suite execution in this environment.tests/optional-shutdown-hooks.test.ts(focused) was not fully exercised due to the prior runtime error; the new tests exercise the optional-shutdown-hooks path and were authored alongside the fix.Codex Task