Skip to content

[WRONG BRANCH] fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id - #289

Draft
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-invalid-wire-ids-in-gemini-tiers
Draft

[WRONG BRANCH] fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id#289
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-invalid-wire-ids-in-gemini-tiers

Conversation

@luvs01

@luvs01 luvs01 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Partial Gemini 3.7 Flash discovery rows (e.g. gemini-3.7-flash-low) were exposed as callable IDs but the runtime path sent them unchanged, which produces invalid upstream CCA requests because CCA expects the single gemini-3.7-flash-tiered wire id plus a thinkingLevel.
  • The change restores the documented contract so partially-discovered 3.7 tier rows resolve to the supported wire id with the corresponding thinkingLevel instead of being treated as suffix/compat ids.

Description

  • Add CURRENT_FLASH_DISCOVERY_TIERS mapping for gemini-3.7-flash-low|medium|high and their corresponding thinking levels in src/providers/antigravity-models.ts.
  • Update resolveAntigravityEffortWireModel to prioritize mapping current Flash discovery tier IDs to GEMINI_FLASH_WIRE_ID (gemini-3.7-flash-tiered) with the matching thinkingLevel before the suffix/alias branch.
  • Preserve existing behavior for retired Flash ids, unknown future tier IDs, and other providers so only the current 3.7 partial-tier case is translated.
  • Add adapter/regression coverage in tests/google-antigravity-wire.test.ts to assert resolver output and adapter request payload include the thinkingConfig for low, medium, and high partial discovery rows.

Testing

  • Ran the focused suite bun test tests/google-antigravity-wire.test.ts and the modified file's tests passed (51 tests, focused Antigravity tests passed including the new assertions).
  • Ran bun run typecheck and it completed successfully (bun x tsc --noEmit).
  • Ran the full bun run test in this environment but it was environment-limited: GUI dependency installs returned HTTP 403 and an unrelated timeout/epoll error occurred, so unrelated integration tests failed in this environment while the focused Antigravity tests and typecheck succeeded locally.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5a5d56b3-739e-45e0-9026-a6becd651d10

📥 Commits

Reviewing files that changed from the base of the PR and between 161c09f and c3c9c2a.

📒 Files selected for processing (2)
  • src/providers/antigravity-models.ts
  • tests/google-antigravity-wire.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c3c9c2a8fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +387 to +389
if (discoveryTier) {
return { wireModelId: GEMINI_FLASH_WIRE_ID, thinkingLevel: discoveryTier };
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Canonicalize partial tier IDs for usage pricing

When live discovery returns a partial Gemini 3.7 tier set and a user selects one of these suffix IDs, this branch makes the request succeed under gemini-3.7-flash-tiered, but the requested suffix remains absent from ANTIGRAVITY_USAGE_BASE_BY_ID. Usage and cost records retain the requested model, and resolveMatchedPrice only falls back to the base price when canonicalAntigravityUsageModel changes that ID, so successful gemini-3.7-flash-low/medium/high calls have no cost estimate despite the existing gemini-3.7-flash price. Map these newly routable IDs to the base model in the usage reverse map and cover the price lookup.

Useful? React with 👍 / 👎.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@github-actions github-actions Bot changed the title fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id [WRONG BRANCH] fix(antigravity): route partial Gemini 3.7 discovery tiers to tiered wire id Aug 15, 2026
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 15, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant