Change DnsOverHttps to query the correct port per Attrleaf - #9650
Open
swankjesse wants to merge 3 commits into
Open
Change DnsOverHttps to query the correct port per Attrleaf#9650swankjesse wants to merge 3 commits into
swankjesse wants to merge 3 commits into
Conversation
yschimke
approved these changes
Aug 10, 2026
| testStateMachineDnsCall { | ||
| val call = | ||
| newCall( | ||
| request = Dns.Request(hostname = "lysine.dev", port = 80), |
Collaborator
There was a problem hiding this comment.
Why not for 80? Isn't 443 the default?
Collaborator
Author
There was a problem hiding this comment.
hmmm... there's a special rule where the presence of an HTTPS record is supposed to automatically promote HTTP to HTTPS.
But I can do that a nicer way, by picking port 443 when we create the query. Let me do that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.