Prevent Enter from sending during IME composition - #2
Open
57wuchi wants to merge 4 commits into
Open
Conversation
Track composition state so Enter confirms Chinese and other IME input before a later Enter sends the message.
Explain that Enter confirms active IME composition and sends only after composition ends.
說明中文輸入法組字時 Enter 只確認選字,組字結束後再次按 Enter 才送出。
Verify the composition guard runs before Enter handling and that the textarea tracks composition lifecycle events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When typing Chinese or other text with an input method editor, Enter is used to confirm the underlined composition candidate. The composer currently handles that same keydown as a send action, which can submit incomplete text before the user has finished composing.
Implementation
compositionstartandcompositionendlifecyclehandleKeydownwhile either the local composition flag orKeyboardEvent.isComposingis activeREADME.mdandREADME.zh-TW.mdwith the expected keyboard behaviorExpected behavior
Testing
node scripts/build.jsnode --test test/*.test.js