merge next-elimBE-new with MRI branch - #3
Merged
Merged
Conversation
Implement some clang-tidy suggestions, use FakeMeshFixtureFCI for tests with FCI parallel transform.
More unit tests
…with C++17 initializer syntax
If the parallel transform is not FCI then parallel slices are not calculated on assignment to Field3DParallel.
…eanup Fix bad PETSc cleanup
Makes the `floor` function lazy, so it can be inlined into template expressions.
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 5 to 7. - [Release notes](https://github.com/astral-sh/setup-uv/releases) - [Commits](astral-sh/setup-uv@v5...v7) --- updated-dependencies: - dependency-name: astral-sh/setup-uv dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Arithmetic operators now use the lazy `BinaryExpr` expressions.
Remove unnecessary data members that dublicate the Field3D::View base.
…imBE" This reverts commit 81befc2.
The vector should be assembled once after importing values. Assembling twice with elimBE over-corrects the RHS.
row_indexes is free'd using HypreFree, so should be allocated using HypreMalloc.
NVCC doesn't accept `Array<int, ArrayData<int>>` as `C<scalar>` so treats ConvertContainer<Array...> as partially specialized. This explicitly writes convertors for Array, Matrix and Tensor containers.
fmt uses `begin` rather than `std::begin` so that NVCC fails to find an overload for `char[]` literals.
Calls `Array::size()` that accesses a shared pointer to `ArrayData`. Doesn't need to be a device function since called outside kernel.
- Remove default arguments for fv_ops specializations - Use base class functions rather than partial overload
Next version for next will be 6.0.0
MeshFactory::create read mesh from data directory
Provides an error message if arkode_mri solver is requested but BOUT++ was built with a version of SUNDIALS lower than 7.2.0
PhysicsModel now has fast and slow preconditioners, and these can be called by the Arkode MRI solver.
Previous use of ARKStepGetNumRhsEvals is deprecated from SUNDIALS 7.2.0, replaced by ARKodeGetNumRhsEvals https://github.com/LLNL/sundials/blob/main/CHANGELOG.md#deprecation-notices
Rather than calling `ARKodeGetCurrentStep` every rhs() call, only call when the `getCurrentTimestep()` method is called.
When run_rhs is called (e.g. by CVODE), all rhs functions are called (rhs_se, rhs_si, rhs_fe, rhs_fi), so all counters need to be incremented.
Fix many includes
merge next-elimBE-new-mri-filter with next-elimBE-new-mri
maggul
marked this pull request as ready for review
September 13, 2026 21:43
maggul
merged commit Sep 13, 2026
588161d
into
next_continuous_temporal_filter
1 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.