Skip to content

fix(cindy-art): preserve configured media provider - #92

Merged
GaoWeiLiuXD merged 2 commits into
makecindy:mainfrom
GaoWeiLiuXD:fix/art-provider-media-preferences
Aug 19, 2026
Merged

fix(cindy-art): preserve configured media provider#92
GaoWeiLiuXD merged 2 commits into
makecindy:mainfrom
GaoWeiLiuXD:fix/art-provider-media-preferences

Conversation

@GaoWeiLiuXD

Copy link
Copy Markdown
Collaborator

What changed / 改了什么

  • Art 从 Host 读取并保留 providerId + modelId,把详情页配置的精确媒体来源交给 Cindy Core。
  • 用户显式点名模型时继续直接按模型目录选择,不依赖 Host 默认配置。
  • Art 版本提升到 1.13.3,最低客户端版本提升到 0.1.56。
  • 同步更新 Art 契约测试,覆盖同 ID 多 Provider 的精确选择。

Why / 为什么

配合客户端 makecindy/cindy#2940 的 Provider-aware 媒体目录和调用契约。同一模型 ID 同时来自 Cindy AI 与第三方 Provider 时,Art 必须保留用户在详情页选择的来源,避免按目录顺序调用到另一 Provider。

Checklist

  • Reviewed the complete diff — no credentials, tokens, authorization codes, real user data, unrelated generated files, or node_modules.
  • ghost.json declares only capabilities actually used; no capability was added.
  • No irreversible external side-effect tool is introduced or changed.
  • Tool declarations remain aligned with behavior; the four existing preparation tools are unchanged.
  • Bumped cindy-art from 1.13.2 to 1.13.3, greater than main.
  • Exact packaged .cindy install on Cindy 0.1.56: 0.1.56 is not released yet and must include client PR #2940; this evidence cannot be recorded truthfully before that release exists.
  • Not a new plugin.
  • Ran the required localization and Art tests.
  • No Node worker or bundled dependency changed.
  • Commit is signed off under DCO.

Tool declaration changes / 工具声明改动

工具名称、参数和触发边界未改变。工具结果中的 request 新增 providerId,并要求 Agent 在 Cindy Core media prepare 时将 modelId/providerId 原样传为 model_id/provider_id

Verification / 验证

  • node --check cindy-art/main.js
  • node --test .tests/localization.test.mjs .tests/provisioning.test.mjs .tests/publish-workflows.test.mjs .tests/cindy-art.test.mjs — 19/19 passed
  • 联合本地开发实例已验证 Provider 模型分别展示和选择;精确 0.1.56 发行包安装待该版本发布后补充。

Sensitive changes / 敏感变更

None / 无。未修改依赖、二进制资源、OAuth/API scope、凭证边界、网络/secret/slot/tool/Node 能力、provisioning audience 或发布策略;minCindyVersion 仅提高,未降低或删除。

Signed-off-by: liugaowei <liugaowei@xd.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 957014cee4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cindy-art/main.js
Comment thread cindy-art/ghost.json
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown

Greptile Summary

存在未处理的 P1:Art 声明的最低客户端版本 0.1.56 尚未完成精确版本 .cindy 安装与核心功能验证。

  • 保留 Host 返回的 providerId + modelId,按精确 Provider 选择媒体目录项并交给 Cindy Core。
  • 四个工具及四语言描述现已明确要求将 modelId/providerId 原样转为 model_id/provider_id
  • Art 版本提升至 1.13.3,最低客户端版本提升至 0.1.56,并增加重复 modelId 的 Provider 选择测试。

Confidence Score: 4/5

PR 在合并前仍需补齐 Art 1.13.3 在精确 Cindy 0.1.56 发行包上的安装与核心功能验证。

Provider 转发契约已在实现、工具描述和测试中同步,但当前仍声明未经精确发行版本实包验证的最低客户端兼容边界。

Files Needing Attention: cindy-art/ghost.json

Important Files Changed

Filename Overview
cindy-art/main.js 配置模型选择现同时匹配 modelId 与 providerId,并在工具结果中返回精确 Provider;已有 Provider 转发问题已修复。
cindy-art/ghost.json 四个工具的 Provider 转发契约已同步,但提高到 0.1.56 的最低客户端边界仍缺少规则要求的精确版本实包验证。
.tests/cindy-art.test.mjs 测试覆盖 Host Provider 选择、重复 modelId 消歧和描述契约,但静态测试不能验证精确客户端版本的实际安装兼容性。
cindy-art/locales/en.json 英文工具描述同步说明 modelId/providerId 的 Core 转发要求。
cindy-art/locales/ja.json 日文工具描述同步说明 modelId/providerId 的 Core 转发要求。
cindy-art/locales/ko.json 韩文工具描述同步说明 modelId/providerId 的 Core 转发要求。
cindy-art/locales/zh-CN.json 中文工具描述同步说明 modelId/providerId 的 Core 转发要求。

Reviews (2): Last reviewed commit: "fix(cindy-art): document provider forwar..." | Re-trigger Greptile

Comment thread cindy-art/ghost.json
Comment thread cindy-art/main.js
Signed-off-by: liugaowei <liugaowei@xd.com>
@GaoWeiLiuXD
GaoWeiLiuXD merged commit 2ff4e21 into makecindy:main Aug 19, 2026
4 checks passed
@GaoWeiLiuXD
GaoWeiLiuXD deleted the fix/art-provider-media-preferences branch August 19, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant