fix(cindy-art): preserve configured media provider - #92
Merged
GaoWeiLiuXD merged 2 commits intoAug 19, 2026
Merged
Conversation
Signed-off-by: liugaowei <liugaowei@xd.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 957014cee4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
| Filename | Overview |
|---|---|
| cindy-art/main.js | 配置模型选择现同时匹配 modelId 与 providerId,并在工具结果中返回精确 Provider;已有 Provider 转发问题已修复。 |
| cindy-art/ghost.json | 四个工具的 Provider 转发契约已同步,但提高到 0.1.56 的最低客户端边界仍缺少规则要求的精确版本实包验证。 |
| .tests/cindy-art.test.mjs | 测试覆盖 Host Provider 选择、重复 modelId 消歧和描述契约,但静态测试不能验证精确客户端版本的实际安装兼容性。 |
| cindy-art/locales/en.json | 英文工具描述同步说明 modelId/providerId 的 Core 转发要求。 |
| cindy-art/locales/ja.json | 日文工具描述同步说明 modelId/providerId 的 Core 转发要求。 |
| cindy-art/locales/ko.json | 韩文工具描述同步说明 modelId/providerId 的 Core 转发要求。 |
| cindy-art/locales/zh-CN.json | 中文工具描述同步说明 modelId/providerId 的 Core 转发要求。 |
Reviews (2): Last reviewed commit: "fix(cindy-art): document provider forwar..." | Re-trigger Greptile
Signed-off-by: liugaowei <liugaowei@xd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed / 改了什么
providerId + modelId,把详情页配置的精确媒体来源交给 Cindy Core。Why / 为什么
配合客户端 makecindy/cindy#2940 的 Provider-aware 媒体目录和调用契约。同一模型 ID 同时来自 Cindy AI 与第三方 Provider 时,Art 必须保留用户在详情页选择的来源,避免按目录顺序调用到另一 Provider。
Checklist
node_modules.ghost.jsondeclares only capabilities actually used; no capability was added.cindy-artfrom 1.13.2 to 1.13.3, greater thanmain..cindyinstall on Cindy 0.1.56: 0.1.56 is not released yet and must include client PR #2940; this evidence cannot be recorded truthfully before that release exists.Tool declaration changes / 工具声明改动
工具名称、参数和触发边界未改变。工具结果中的
request新增providerId,并要求 Agent 在 Cindy Core mediaprepare时将modelId/providerId原样传为model_id/provider_id。Verification / 验证
node --check cindy-art/main.jsnode --test .tests/localization.test.mjs .tests/provisioning.test.mjs .tests/publish-workflows.test.mjs .tests/cindy-art.test.mjs— 19/19 passedSensitive changes / 敏感变更
None / 无。未修改依赖、二进制资源、OAuth/API scope、凭证边界、网络/secret/slot/tool/Node 能力、provisioning audience 或发布策略;
minCindyVersion仅提高,未降低或删除。