feat(sms-bridge): select approved Messaging Service - #237
Open
xnoto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selects the already published one-sender outbound path for
opencode-sms-bridge:opencode-sms-bridgechart0.1.3;9ae1ead0f55c7040cdc7bdd3611718bc6b56cf62; andconfig.messagingServiceSid.This switches compatible worker replies from direct
from_sending to Twilio Messaging Service sending. The canonical inbound webhook URL, existing encrypted Secrets, routing/allowlist, PVC, Service, TunnelBinding, Argo policy, namespace, sync wave, and overlay source are unchanged.Fixes #
N/A — owner-approved A2P sender-selection remediation.
Type of change
Validation
testrun 34326470728 passed Kustomization-reference checks and pre-commit (including gitleaks and kube-linter) atc25baa5fd56db252576cc2c435079d6c4db54a4a.Producer evidence already verified:
0.1.3after main chart CI; it wires the non-secret value into the worker-only ConfigMap environment.Adversarial and infrastructure-security reviews advanced this source change. The reviews record two accepted runtime dependencies: Campaign/sender association is owner-attested rather than repository-verifiable, and CI cannot prove the provider selects the intended sender. Repository CI also cannot render KSOPS/Helm OCI sources or prove Argo/runtime delivery; those remain post-merge verification gates. No local OpenTofu, Helm, SOPS, Kubernetes, or Twilio operation was run or claimed.
Impact and rollout
Producers:
makeitworkcloud/imagesowns the bridge image;makeitworkcloud/chartsowns chart rendering;makeitworkcloud/tfroot-twilioowns the Messaging Service/sender-pool declaration.Consumer: this change is the final
makeitworkcloud/kustomize-clusterselection gate atworkloads/apps/opencode-sms-bridge-app.yaml. It introduces no Secret, SOPS/KSOPS generator, RBAC, network exposure, DNS, TunnelBinding, or Cloudflare change.After a separately confirmed merge,
test.ymlruns onmain; on success,sync.ymlrequests reconciliation of the App-of-Apps roots. It does not wait for reconciliation. Verify separately:gitops-workloadsandopencode-sms-bridgeselected revisions,Synced/Healthystate, resource tree, rendered ConfigMap/worker environment, Deployment/pods/events, and—only with separate approval—one controlled allowed-sender inbound-to-outbound delivery test confirming the Messaging Service sender.Rollback: use a focused Git revert through normal CI/Argo reconciliation; do not manually patch, sync, or restart resources. The prior chart/image selection remains available as the known direct-sender rollback path.
Safety and secrets
AI-assisted change: an OpenCode agent materially produced this change. Reviewers should verify the chart/image pins, non-secret worker-only configuration, unchanged inbound path, and remaining Twilio/Argo runtime gates.