Skip to content

feat(fragments): add command with open-changelist append + per-branch impact caps - #2

Open
manuc66 wants to merge 13 commits into
mainfrom
feat/fragment-changelist-ux
Open

feat(fragments): add command with open-changelist append + per-branch impact caps#2
manuc66 wants to merge 13 commits into
mainfrom
feat/fragment-changelist-ux

Conversation

@manuc66

@manuc66 manuc66 commented Aug 22, 2026

Copy link
Copy Markdown
Owner

Summary

Solves the "too many fragment files per MR" friction and adds a per-branch impact cap. Stacked on #1 (gates + API-surface dogfooding): the diff shrinks to this feature alone once #1 merges.

What changed

1. changesharp add — the open changelist

  • add appends a change to the most recent fragment (the open changelist), so a feature branch accumulates into a single file.
  • Trunk-safe: on the default branch (main/master) add always creates a separate file → concurrent pushes stay conflict-free.
  • Escape hatches: --separate (new file), --fragment <file> (specific target), --changelist <name> (deterministic named changelist).
  • new remains equivalent to add --separate (backward compatible).
  • The MaxImpact cap applies to add exactly as to new.

2. Per-branch impact caps (SemverPolicy.BranchMaxImpact)

{ "SemverPolicy": { "MaxImpact": "minor", "BranchMaxImpact": { "release/*": "patch" } } }
  • On a release/1.2 branch, an Added (Minor) fragment is refused at add and release (exit 3) unless --allow-major; Fixed (Patch) is fine.
  • Effective cap = min(global MaxImpact, matching branch entry). * suffix wildcard supported.

3. MCP parity

create_fragment gains separate / fragment / changelist params (same semantics as the CLI).

Tests

  • AppendFragment (append same/new section, create, dedup, changelist/fragment/separate targets, default-branch vs feature-branch via git) and BranchMaxImpact (matching/non-matching branch, gate messages): 16 new tests → 130 total, all green.
  • Baselines regenerated (cli-help.txt, mcp-tools.json, public-api.txt); the api-surface job derives minor (additions only).
  • Demo samples/maximpact-gate/run-demo.sh: 11/11.

Verified manually

  • Feature branch: 2 × add → 1 file, 2 sections.
  • main: 2 × add → 2 files (trunk-safe).
  • release/1.0 + BranchMaxImpact: release/* → patch: add --added exit 3 ("above the allowed impact (patch)"), add --fixed OK.

…e gate

- SemverPolicy.MaxImpact (default major = cap off): fragments/releases that
  would force a Major bump are refused at new and release unless --allow-major
  is passed. Interactive menu marks blocked categories and re-prompts.
- MCP tools expose the gates: validate_fragments apiMinLevel, perform_release
  allowMajor/apiMinLevel.
- Dogfood the API Surface Gate on ChangeSharp itself: committed baselines
  (tests/public-api: cli-help, mcp-tools, public-api via PublicApiGenerator),
  scripts/update-public-api.sh, api-surface CI job, PublicApiBaselineTests.
- Demo workspace samples/maximpact-gate with self-verifying run-demo.sh.
- Docs updated (SemVer Rules, ApiSurfaceGate, McpIntegration, Roadmap).
- MCP create_fragment now enforces SemverPolicy.MaxImpact with an allowMajor
  opt-in, matching the CLI new command (review finding).
- Regenerate mcp-tools.json baseline (create_fragment schema).
- Document that prerelease create/promote bypass the gates (pre-existing
  behavior, shared with --api-min-level), that cli-help rewording is treated
  conservatively as major by the api-surface heuristic, and that
  scripts/update-public-api.sh requires jq (now checked up front).
…-major

- Add WorkspaceManager.GetCreateFragmentError and GetReleaseGateResult so the
  CLI and MCP share the exact same gate sequence (floor then cap), removing the
  CLI/MCP orchestration drift (create_fragment had been missed initially; gate
  vs security precedence differed).
- Add NextVersionComputer.ImpactName; drop the duplicated CLI/MCP helpers.
- Record the explicit --allow-major decision in release output (CLI warning +
  JSON warnings; MCP response text) as an audit trail.
- Extend samples/maximpact-gate/run-demo.sh with MCP e2e gate scenarios (11/11).
- Note the MaxImpact/Mappings interaction (Changed->Major + minor cap blocks
  Changed) in SemVer Rules.
- Regenerate public-api.txt baseline (+ImpactName, +GetCreateFragmentError,
  +GetReleaseGateResult).
- Extract RenderCategoryMenu and ApplyCategoryKey out of PromptForCategory.
- Extract BumpForImpact out of ComputeVersionWithWarning (behavior preserved,
  covered by the existing SemVer tests).
@manuc66
manuc66 changed the base branch from feat/safety-gates-and-api-surface-dogfooding to main August 22, 2026 19:32
@manuc66

manuc66 commented Aug 22, 2026

Copy link
Copy Markdown
Owner Author

Reopening to trigger CI after base retarget to main.

@manuc66 manuc66 closed this Aug 22, 2026
@manuc66 manuc66 reopened this Aug 22, 2026
@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.54545% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.86%. Comparing base (07d4d25) to head (84c7a2a).

Files with missing lines Patch % Lines
ChangeSharp/WorkspaceManager.cs 85.89% 9 Missing and 13 partials ⚠️
ChangeSharp/NextVersionComputer.cs 82.60% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   78.33%   80.86%   +2.53%     
==========================================
  Files          12       14       +2     
  Lines        1154     1406     +252     
  Branches      194      237      +43     
==========================================
+ Hits          904     1137     +233     
- Misses        183      193      +10     
- Partials       67       76       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

… impact caps

- New 'add' command: appends a change to the most recent fragment (the open
  changelist); on the default branch it always creates a separate file so
  concurrent trunk pushes stay conflict-free. Escape hatches: --separate,
  --fragment <file>, --changelist <name>. 'new' stays equivalent to
  'add --separate'.
- SemverPolicy.BranchMaxImpact: per-branch impact caps (e.g. release/* -> patch)
  that restrict branches to a lower impact; effective cap = min(global, branch).
  Applies at add/new and release through the existing MaxImpact gates.
- MCP create_fragment gains separate/fragment/changelist params.
- AppendFragment + IsDefaultBranch in the library; 16 new tests (130 total).
- Docs (SemVer Rules, McpIntegration, Roadmap) and baselines regenerated.
@manuc66
manuc66 force-pushed the feat/fragment-changelist-ux branch from 54ef819 to 33bb48a Compare August 22, 2026 19:49
…face gate

- changesharp validate --api-surface regenerates the CLI help, MCP tools, and
  library public API in memory, checks the committed baselines (tests/public-api),
  derives the impact vs origin/main, and gates the fragments - all in one step.
- Move MCP tool definitions into the library (McpToolCatalog) as a single source;
  the MCP server and the surface check both use it.
- PublicSurfaceValidator (BaselinesMatch, DeriveImpact) in the library, JSON-aware
  comparison, fully unit-tested.
- The api-surface CI job collapses from a multi-step bash heuristic to a single
  'changesharp validate --api-surface' step.
- GenerateCliHelp renders under invariant culture so the baseline is stable.
- 15 new tests (145 total); baselines regenerated.
- Shared options become static fields; each command (init, new, add, status,
  validate, release, publish, prerelease, remove) gets a dedicated builder
  method, removing the 700-line long-method CodeFactor finding.
- Behavior and help output are byte-identical (baselines unchanged).
…ve helpers

- new and add now share RunFragmentAction (forceSeparate flag); the duplicate
  message/category/gate flow is gone. CategoryFromFlags extracted.
- validate/release/remove extract their sub-branches (CheckApiMinLevelGate,
  ShowDryRun, ShowFragmentList, RemoveAllFragments, ShowRemoveUsage,
  RemoveSingleFragment) to drop the remaining long-method CodeFactor findings.
- Help output unchanged (baselines identical).
- new/add: RunFragmentAction is now a thin loop over ResolveFragmentMessage,
  ChooseCategory, and TryAppendFragment (retry sentinel for interactive re-prompt).
- validate: rendering extracted into ReportValidationErrors/ReportValidationSuccess.
- release: pre-checks (ResolveDryRun, CheckApproval) and FinishRelease extracted;
  the action is now an orchestrator.
- Behavior and help output unchanged (baselines identical).
Dogfoods the MaxImpact cap, the add/append command, and the MCP gates
(create_fragment / perform_release) end-to-end on every PR and push.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant