feat(fragments): add command with open-changelist append + per-branch impact caps - #2
Open
manuc66 wants to merge 13 commits into
Open
feat(fragments): add command with open-changelist append + per-branch impact caps#2manuc66 wants to merge 13 commits into
manuc66 wants to merge 13 commits into
Conversation
…e gate - SemverPolicy.MaxImpact (default major = cap off): fragments/releases that would force a Major bump are refused at new and release unless --allow-major is passed. Interactive menu marks blocked categories and re-prompts. - MCP tools expose the gates: validate_fragments apiMinLevel, perform_release allowMajor/apiMinLevel. - Dogfood the API Surface Gate on ChangeSharp itself: committed baselines (tests/public-api: cli-help, mcp-tools, public-api via PublicApiGenerator), scripts/update-public-api.sh, api-surface CI job, PublicApiBaselineTests. - Demo workspace samples/maximpact-gate with self-verifying run-demo.sh. - Docs updated (SemVer Rules, ApiSurfaceGate, McpIntegration, Roadmap).
- MCP create_fragment now enforces SemverPolicy.MaxImpact with an allowMajor opt-in, matching the CLI new command (review finding). - Regenerate mcp-tools.json baseline (create_fragment schema). - Document that prerelease create/promote bypass the gates (pre-existing behavior, shared with --api-min-level), that cli-help rewording is treated conservatively as major by the api-surface heuristic, and that scripts/update-public-api.sh requires jq (now checked up front).
…-major - Add WorkspaceManager.GetCreateFragmentError and GetReleaseGateResult so the CLI and MCP share the exact same gate sequence (floor then cap), removing the CLI/MCP orchestration drift (create_fragment had been missed initially; gate vs security precedence differed). - Add NextVersionComputer.ImpactName; drop the duplicated CLI/MCP helpers. - Record the explicit --allow-major decision in release output (CLI warning + JSON warnings; MCP response text) as an audit trail. - Extend samples/maximpact-gate/run-demo.sh with MCP e2e gate scenarios (11/11). - Note the MaxImpact/Mappings interaction (Changed->Major + minor cap blocks Changed) in SemVer Rules. - Regenerate public-api.txt baseline (+ImpactName, +GetCreateFragmentError, +GetReleaseGateResult).
- Extract RenderCategoryMenu and ApplyCategoryKey out of PromptForCategory. - Extract BumpForImpact out of ComputeVersionWithWarning (behavior preserved, covered by the existing SemVer tests).
manuc66
changed the base branch from
feat/safety-gates-and-api-surface-dogfooding
to
main
August 22, 2026 19:32
Owner
Author
|
Reopening to trigger CI after base retarget to main. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 78.33% 80.86% +2.53%
==========================================
Files 12 14 +2
Lines 1154 1406 +252
Branches 194 237 +43
==========================================
+ Hits 904 1137 +233
- Misses 183 193 +10
- Partials 67 76 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… impact caps - New 'add' command: appends a change to the most recent fragment (the open changelist); on the default branch it always creates a separate file so concurrent trunk pushes stay conflict-free. Escape hatches: --separate, --fragment <file>, --changelist <name>. 'new' stays equivalent to 'add --separate'. - SemverPolicy.BranchMaxImpact: per-branch impact caps (e.g. release/* -> patch) that restrict branches to a lower impact; effective cap = min(global, branch). Applies at add/new and release through the existing MaxImpact gates. - MCP create_fragment gains separate/fragment/changelist params. - AppendFragment + IsDefaultBranch in the library; 16 new tests (130 total). - Docs (SemVer Rules, McpIntegration, Roadmap) and baselines regenerated.
manuc66
force-pushed
the
feat/fragment-changelist-ux
branch
from
August 22, 2026 19:49
54ef819 to
33bb48a
Compare
…face gate - changesharp validate --api-surface regenerates the CLI help, MCP tools, and library public API in memory, checks the committed baselines (tests/public-api), derives the impact vs origin/main, and gates the fragments - all in one step. - Move MCP tool definitions into the library (McpToolCatalog) as a single source; the MCP server and the surface check both use it. - PublicSurfaceValidator (BaselinesMatch, DeriveImpact) in the library, JSON-aware comparison, fully unit-tested. - The api-surface CI job collapses from a multi-step bash heuristic to a single 'changesharp validate --api-surface' step. - GenerateCliHelp renders under invariant culture so the baseline is stable. - 15 new tests (145 total); baselines regenerated.
- Shared options become static fields; each command (init, new, add, status, validate, release, publish, prerelease, remove) gets a dedicated builder method, removing the 700-line long-method CodeFactor finding. - Behavior and help output are byte-identical (baselines unchanged).
…ve helpers - new and add now share RunFragmentAction (forceSeparate flag); the duplicate message/category/gate flow is gone. CategoryFromFlags extracted. - validate/release/remove extract their sub-branches (CheckApiMinLevelGate, ShowDryRun, ShowFragmentList, RemoveAllFragments, ShowRemoveUsage, RemoveSingleFragment) to drop the remaining long-method CodeFactor findings. - Help output unchanged (baselines identical).
- new/add: RunFragmentAction is now a thin loop over ResolveFragmentMessage, ChooseCategory, and TryAppendFragment (retry sentinel for interactive re-prompt). - validate: rendering extracted into ReportValidationErrors/ReportValidationSuccess. - release: pre-checks (ResolveDryRun, CheckApproval) and FinishRelease extracted; the action is now an orchestrator. - Behavior and help output unchanged (baselines identical).
Dogfoods the MaxImpact cap, the add/append command, and the MCP gates (create_fragment / perform_release) end-to-end on every PR and push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solves the "too many fragment files per MR" friction and adds a per-branch impact cap. Stacked on #1 (gates + API-surface dogfooding): the diff shrinks to this feature alone once #1 merges.
What changed
1.
changesharp add— the open changelistaddappends a change to the most recent fragment (the open changelist), so a feature branch accumulates into a single file.main/master)addalways creates a separate file → concurrent pushes stay conflict-free.--separate(new file),--fragment <file>(specific target),--changelist <name>(deterministic named changelist).newremains equivalent toadd --separate(backward compatible).MaxImpactcap applies toaddexactly as tonew.2. Per-branch impact caps (
SemverPolicy.BranchMaxImpact){ "SemverPolicy": { "MaxImpact": "minor", "BranchMaxImpact": { "release/*": "patch" } } }release/1.2branch, anAdded(Minor) fragment is refused ataddandrelease(exit 3) unless--allow-major;Fixed(Patch) is fine.MaxImpact, matching branch entry).*suffix wildcard supported.3. MCP parity
create_fragmentgainsseparate/fragment/changelistparams (same semantics as the CLI).Tests
AppendFragment(append same/new section, create, dedup, changelist/fragment/separate targets, default-branch vs feature-branch via git) andBranchMaxImpact(matching/non-matching branch, gate messages): 16 new tests → 130 total, all green.cli-help.txt,mcp-tools.json,public-api.txt); theapi-surfacejob derivesminor(additions only).samples/maximpact-gate/run-demo.sh: 11/11.Verified manually
add→ 1 file, 2 sections.main: 2 ×add→ 2 files (trunk-safe).release/1.0+BranchMaxImpact: release/* → patch:add --addedexit 3 ("above the allowed impact (patch)"),add --fixedOK.