Skip to content

Fixed missing null terminator in config string used in Booster::save_buffer. #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
metasim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed missing null terminator in config string used in Booster::save_buffer. #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/booster.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,16 @@ impl Booster {
/// Format is "ubj" when binary, otherwise "json"
pub fn save_buffer(&self, binary: bool) -> XGBResult<Vec<u8>> {
trace!("Writing Booster to buffer");
let config = format!("{{\"format\":\"{}\"}}", if binary { "ubj" } else { "json" });
// Must be NUL-terminated: XGBoost treats this as a C string and calls
// strlen on it. Passing a bare Rust String's bytes (no trailing NUL)
// makes XGBoost read past the end of the allocation.
let config = ffi::CString::new(format!("{{\"format\":\"{}\"}}", if binary { "ubj" } else { "json" }))
.map_err(|e| XGBError::new(e.to_string()))?;
let mut out_len: xgboost_sys::bst_ulong = 0;
let mut out_buffer = ptr::null();
xgb_call!(xgboost_sys::XGBoosterSaveModelToBuffer(
self.handle,
config.as_bytes().as_ptr() as *const raw::c_char,
config.as_ptr() as *const raw::c_char,
&mut out_len,
&mut out_buffer
))?;
Expand Down