Skip to content

.remove() on instance that has old values doesn't delete everything #182

Description

@maritz

When an instance is removed, it only removes indices/uniquelocks for the values that have been loaded into that instance.

A static .remove() (aka with an unloaded instance or on the static class) does a load immediately before removing and thus rarely runs into this issue, but it still isn't atomic.

Instead a more thorough live search of ids in all indices has to be performed. This is costly, so it would also be a good target for future improvements by making it a lua script.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions