Harden and validate the v2.0.0 UPM release - #5
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d50fe699f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| len(all_cases) != total | ||
| or len(skipped) != skipped_count | ||
| or not skipped.issubset(allowed_skips) |
There was a problem hiding this comment.
When the minimal GameCI project does not expose virtual UPM mounts through System.IO, GitSubmoduleAddServiceTests.PhysicalPresence_IgnoresUnityVirtualPackageMount intentionally calls Assert.Ignore (Tests/Editor/GitSubmoduleAddServiceTests.cs:87-101). Its fullname is absent from allowed_skips, so this predicate rejects an otherwise successful Unity run and blocks publishing; the same omission also affects the sanity workflow's verifier.
Useful? React with 👍 / 👎.
1 participant
Summary
.tgzin clean Unity projects before publishing the same bytesVerification
.tgzsuite on Unity 6000.3.22f1: 971 total, 968 passed, 0 failed, 3 allowed headless skips.tgzsuite on Unity 6000.5.10f1: 971 total, 968 passed, 0 failed, 3 allowed headless skips24af1f02d057276eb2c0bf31c9605099490caedb16be203447c3d47887fef213Release gate
Do not create
v2.0.0until the protectedunity-cienvironment has Unity credentials and direct collaborator release authority has been resolved.