Skip to content

Feat/add weapon type bonus - #3698

Open
LPfontes wants to merge 3 commits into
massif-press:devfrom
LPfontes:feat/add-weapon-type-bonus
Open

Feat/add weapon type bonus#3698
LPfontes wants to merge 3 commits into
massif-press:devfrom
LPfontes:feat/add-weapon-type-bonus

Conversation

@LPfontes

@LPfontes LPfontes commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds support for the add_weapon_type bonus in COMP/CON to dynamically grant additional weapon types to weapons based on active frame traits or bonuses (e.g., the SSC Viceroy frame from Dustgrave, which treats Launcher weapons as also being CQB weapons).

Key changes:

  • Registered add_weapon_type bonus in bonus_dictionary.ts and BonusController.ts.
  • Dynamically evaluate active add_weapon_type bonuses inside MechWeapon.getWeaponTypes(mech).
  • Updated _ModSelector.vue and Mech.HasCompatibleMods() to validate weapon mods against all dynamically evaluated weapon types instead of just the static base type.
  • Updated UI weapon cards (_WeaponSlotCard.vue and _mechWeaponCard.vue) to display dynamically evaluated weapon types (e.g., Launcher / CQB).

Note: The add_weapon_type bonus ID should be added to the LCP Wiki Data Specification documentation so content authors can reference and utilize this bonus for LCP content packs.

Note: it is necessary to update the Near-Threat Targeting Processor in the lcp Dustgrave with the following code

{
"name": "Near-Threat Targeting Processor",
"description": "The Viceroy treats its LAUNCHER weapons as though they are also CQB weapons with THREAT 3.",
"bonuses": [
{
"id": "add_weapon_type",
"val": "CQB",
"weapon_types": ["Launcher"]
},
{
"id": "threat",
"val": 3,
"weapon_types": ["Launcher"],
"replace": true
}
],
"synergies": [
{
"locations": ["weapon"],
"weapon_types": ["Launcher"],
"weapon_sizes": ["any"],
"detail": "This weapon is treated as though it were also a CQB weapon with THREAT 3."
}
]
},
Closes #3439

Type of Change

  • Bug fix (fix:)
  • New feature (feat:)
  • Refactor (refactor:)
  • Documentation (docs:)
  • Maintenance / Build (chore: / build: / ci:)
  • Breaking change

Checklist

  • My commits follow Conventional Commits format
  • I have tested this change locally
  • I have updated relevant documentation (if applicable)
  • I have added/updated types for any changed interfaces
  • This change is backwards-compatible (or marked as breaking)

Screenshots (if UI change)

Captura de tela 2026-08-05 162954 Captura de tela 2026-08-05 162942 Captura de tela 2026-08-05 163014 Captura de tela 2026-08-05 163913

…ctor validation

- Add ADD_WEAPON_TYPE bonus definition to bonus_dictionary and BonusController
- Dynamically evaluate add_weapon_type bonuses in MechWeapon.getWeaponTypes()
- Update _ModSelector and Mech.HasCompatibleMods() to check all evaluated weapon types against allowed mod types
@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

👷 Deploy request for cc-dev-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c666478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant