Keep LICENSE as plain MIT so GitHub detects it - #3
Merged
Conversation
GitHub's license detector reported NOASSERTION because LICENSE carried a trailing note about the assets. Any appended text breaks the match, so a public repository lost its license badge. The MIT text is now untouched. The code/art boundary moves to where people actually read it: a line under the title, the table further down, and the top of ASSETS-LICENSE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub reported
NOASSERTIONinstead of MIT: the trailing note about assets inLICENSEbroke the detector, and a public repo lost its license badge.LICENSEis now untouched MIT text. The code/art boundary moves to where it is actually read:ASSETS-LICENSE.md, now explicit that the MIT grant covers the code and nothing elseNo change to the licensing decision itself.