Fix homepage search after query navigation - #105
Merged
Merged
Conversation
🧹 Code quality
updated for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Nuxt reuses the homepage component when only query parameters change, but the local search state was initialized only once. After synchronizing that state, a second Nuxt async-data edge case remained:
immediate: falsecreated a new fetch key for the updated query without executing it, while the query watcher was suppressed during that key transition.Impact
Homepage searches initiated through typing, WebMCP, or browser back/forward navigation now fetch and render results without requiring a page refresh.
Validation
bunx vize fmt --check app/pages/index.vuebunx vize lint app/pages/index.vue(passes with six pre-existing template-style warnings)/to/?search=cheaperrequested/api/search/quick?q=cheaperand renderedCheaper access to clean watercheaper