fix(compose): make the agent's docker group GID configurable - #3
Merged
Conversation
The agent was pinned to user "10001:988" in both compose files. 988 was the docker group GID on the previous VM; on the replacement host it is 998, so the agent could not read /var/run/docker.sock and every Docker query failed with "Permission denied (os error 13)". The orchestrator surfaced that as a 500, leaving the Docker panel empty - the one feature set still fully functional now that the cluster is gone. Reads DOCKER_GID from the environment with a 998 default, and documents in .env.example how to find the right value for a host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while migrating to the replacement VM after the old Azure subscription was disabled.
Problem
Both compose files pinned the agent to
user: "10001:988".988was the docker group GID on the previous host. On the new VM it is998, so the agent could not read/var/run/docker.sock:The orchestrator surfaced that as a 500 and the Docker panel came up empty — the one feature set still fully functional now that there is no cluster.
Because
docker-compose.prod.ymlalso setuser:, patching only the base file had no effect; the override won.Fix
in both files, plus
.env.exampledocumenting how to find the value:Already applied on the running host, where the agent now lists all 7 containers correctly. This commit is what makes it survive
deploy.sh'sgit reset --hard.Note
A hardcoded host GID in a committed compose file is portable right up until the host changes. The default keeps existing behaviour on a matching host; the variable makes the next migration a one-line
.envchange instead of a debugging session.