Skip to content

Fix typo to match command location and C Makefile target - #2

Open
djui wants to merge 1 commit into
mattsta:masterfrom
djui:patch-2
Open

Fix typo to match command location and C Makefile target#2
djui wants to merge 1 commit into
mattsta:masterfrom
djui:patch-2

Conversation

@djui

@djui djui commented Sep 29, 2011

Copy link
Copy Markdown
Contributor

No description provided.

@mattsta

mattsta commented Sep 29, 2011

Copy link
Copy Markdown
Owner

Is this commit right? The Makefile has:

 ../priv/stdin_forcer: stdin_forcer.c
      @mkdir -p ../priv
      $(CC) -Wall -Werror -pedantic -ansi -O2 -o ../priv/stdin_forcer stdin_forcer.c

Looks like changing the loader to get_base_dir(?MODULE) ++ "/priv/stdinout_forcer" would not find stdin_forcer.

@djui

djui commented Sep 29, 2011

Copy link
Copy Markdown
Contributor Author

Btw: maybe it's possible to use your project as library application, start it using application:start(stdinout) and then just use code:priv_dir(). Should make it cleaner.

@mattsta

mattsta commented Sep 29, 2011

Copy link
Copy Markdown
Owner

Good point about turning it into an application.

Maybe version 2.0 will be application + consistent naming + better worker pool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants