Reference auth provider factory FQCNs instead of removed service IDs - #612
Draft
promptless-for-oss wants to merge 1 commit into
Draft
Reference auth provider factory FQCNs instead of removed service IDs#612promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
mautic/mautic PR #16875 removes the unused string service IDs mautic.integrations.auth_provider.api_key, .basic_auth, and .token_persistence_factory. Update the integration authentication guide to reference the factory classes by FQCN, which stay autowire-injectable, so copied guidance keeps working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
mautic/mautic PR #16875 ("[config] remove unused service aliases") removes the unused string container service IDs
mautic.integrations.auth_provider.api_key,mautic.integrations.auth_provider.basic_auth, andmautic.integrations.auth_provider.token_persistence_factory. The plugin integration authentication guide named these string IDs as "the service to use", so that guidance goes stale once the PR merges.This updates the three affected sentences (API key, Basic auth, and Token persistence sections) to reference the factory classes by their Fully Qualified Class Name, which stay autowire-injectable and are already used in the page's own code samples. The
mautic.integrations.helperreference is left unchanged because that service ID is not removed by the PR.Files touched:
docs/plugin_integrations/integrations_authentication.rst.Trigger Events