Document 1000-char limit for report-transaction notes - #1671
Conversation
Deploying dev-site with
|
| Latest commit: |
69f2212
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8594782b.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://faktas-document-notes-limit.dev-site-4ua.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the transaction reporting documentation to specify a limit of 1000 Unicode characters for the notes field and adds the corresponding NOTES_INVALID error code. The reviewer pointed out a style guide violation where a comma should be added before the conjunction "so" in the notes field description.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| | **maxmind_id** | string (8) | _Conditionally required.[^1]_ A unique eight character string identifying a minFraud Standard or Premium request. These IDs are returned in the `maxmindID` field of a response for a successful minFraud request. | | ||
| | **minfraud_id** | string (36) | _Conditionally required.[^1]_ A UUID that identifies a minFraud Score, minFraud Insights, or minFraud Factors request. This ID is returned at `/id` in the response. | | ||
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. | | ||
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | |
There was a problem hiding this comment.
According to the repository style guide, a comma should be used between independent clauses joined by conjunctions (such as "so"). Please add a comma before "so".
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | | |
| | **notes** | string | _Optional._ Your notes on the fraud tag associated with the transaction. We manually review many reported transactions to improve our scoring for you, so any additional details to help us understand context are helpful. Must be 1000 Unicode characters or fewer. | |
References
- Use commas between independent clauses joined by conjunctions. (link)
Add the character limit to the notes field description and add the NOTES_INVALID error code to the response error table. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
68ed608 to
ba0e63d
Compare
|
@faktas2 is someone reviewing this PR? |
|
@faktas2 see above |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe transaction report documentation now limits ChangesTransaction notes documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 participants
Summary
notesfield description in the Request Body tableNOTES_INVALIDerror code to the Response error tableRelated to internal issue UHU-2728.
Summary by CodeRabbit
NOTES_INVALID400 Bad Request error returned when notes exceed the limit.