Fix markdown prettier formatting and guard dependency-update PRs - #1709
Merged
Conversation
The Precious job only linted files changed in a PR (--git-diff-from), so reformats caused by the PR itself -- such as a dependency bump that changes a formatter's version -- went unnoticed until the post-merge push-to-main run linted everything. The repo is small, so always lint every file on both pull_request and push events.
Deploying dev-site with
|
| Latest commit: |
19c5e7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f77d3b20.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://fix-prettier-markdown-format.dev-site-4ua.pages.dev |
oschwald
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Greg Oschwald · Slack thread
Summary
The
Precious/ Code Formatting check is currently red onmain, and this PR makes it green while closing the CI gap that let the failure land.Before/After: Before this PR,
precious lint --all(the check that runs on push-to-main) fails on two markdown files. After this PR, the formatting check passes, and dependency-update PRs will surface whole-repo reformats before merge instead of only after.Root cause
PR #1706 bumped
prettierfrom 3.8.4 to 3.9.5 (a Dependabot devDependency group bump). Prettier 3.9.5 changed its markdown output (blank lines are now inserted around HTML comments inside lists), which reformats two existing files.That PR's own CI passed because the
code-formattingjob linted only the files changed in the PR onpull_requestevents (--git-diff-from origin/$BASE_REF), while push-to-mainlinted everything (--all). Since #1706 changed onlypackage.jsonandpnpm-lock.yaml, no markdown was linted on the PR, and the failure surfaced only on the post-merge push-to-mainrun.Changes
content/minfraud/release-notes/2015.mdcontent/minfraud/whats-new-in-minfraud-score-and-minfraud-insights.md.github/workflows/precious.ymlnow runsprecious lint --allon bothpull_requestandpushevents, dropping the changed-files-only path for PRs. This removes the split that hid the failure: a PR that reformats files outside its own diff (for example, a dependency bump that changes a formatter version) is now caught pre-merge. The repo is small, so linting everything on every PR is cheap. The now-unusedBASE_REFenv, "Fetch base ref" step, and "Select files" step were removed.