docs: freeze audit, demo assets, SUBMISSION landing page - #11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares a freeze-ready submission package for the tinyexpr C→Zig port by adding a landing page and comprehensive evidence/demo artifacts, while also fixing a Zig 0.16 compatibility issue and redacting some host-specific paths in logs.
Changes:
- Add
SUBMISSION.mdlanding page and a write-up draft, and link them from the README. - Add demo transcript capture tooling plus committed SVG/segment assets for the submission demo.
- Update evidence logs/transcripts (freeze-regen, suite transcripts, bench methodology) and fix a Zig allocator usage in a regression test.
Reviewed changes
Copilot reviewed 41 out of 49 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/port/parser_leak.zig | Switch regression test allocator to DebugAllocator for Zig 0.16 compatibility. |
| SUBMISSION.md | New submission landing page summarizing commands, evidence, and claims. |
| README.md | Add prominent link to SUBMISSION.md and embed demo SVG. |
| examples/c-consumer/run-log.txt | Redact absolute local path from example run log. |
| docs/writeup.md | New write-up draft documenting key technical decisions and results. |
| docs/journal.md | Add freeze-audit journal entry and audit outcomes. |
| docs/evidence/self-audit.md | New self-audit checklist and dispositions for freeze. |
| docs/evidence/repro/run-log-darwin.txt | Redact absolute local paths in Darwin repro log excerpts. |
| docs/evidence/original-suite-pow-zig-static.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-pow-c-original.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-pow_natlog-zig-static.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-pow_natlog-c-original.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-natlog-zig-static.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-natlog-c-original.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-default-zig-static.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/original-suite-default-c-original.txt | Update suite transcript metadata for current freeze run. |
| docs/evidence/nm-smoke-pow-zig-static.txt | Update nm/smoke evidence artifact content. |
| docs/evidence/nm-smoke-pow_natlog-zig-static.txt | Update nm/smoke evidence artifact content. |
| docs/evidence/nm-smoke-natlog-zig-static.txt | Update nm/smoke evidence artifact content. |
| docs/evidence/nm-smoke-default-zig-static.txt | Update nm/smoke evidence artifact content. |
| docs/evidence/freeze-regen/zero-clone-summary.txt | New freeze-regen “zero-clone” verification summary. |
| docs/evidence/freeze-regen/suites.done | New freeze-regen completion marker with timestamp/SHA. |
| docs/evidence/freeze-regen/suite-pow-zig.txt | New freeze-regen suite transcript (pow). |
| docs/evidence/freeze-regen/suite-pow_natlog-zig.txt | New freeze-regen suite transcript (pow+natlog). |
| docs/evidence/freeze-regen/suite-natlog-zig.txt | New freeze-regen suite transcript (natlog). |
| docs/evidence/freeze-regen/suite-default-zig.txt | New freeze-regen suite transcript (default). |
| docs/evidence/freeze-regen/live-diff.txt | New freeze-regen “live upstream diff” transcript. |
| docs/evidence/freeze-regen/hashes.txt | New freeze-regen original-hash verification transcript. |
| docs/demo/segments/01-hashes.txt | New demo segment transcript: hashes/upstream verification. |
| docs/demo/segments/02-suite-default.txt | New demo segment transcript: default suite run. |
| docs/demo/segments/03-four-configs.txt | New demo segment transcript: four-config summary. |
| docs/demo/segments/04-nest-contrast.txt | New demo segment transcript: nest-crash contrast. |
| docs/demo/segments/05-fuzz-log.txt | New demo segment transcript: fuzz certification excerpt. |
| docs/demo/segments/06-hatch-gate.txt | New demo segment transcript: escape-hatch gate demo. |
| docs/demo/segments/07-one-command.txt | New demo segment transcript: one-command summary. |
| docs/demo/01-hashes.svg | New rendered SVG for demo segment 01. |
| docs/demo/02-suite-default.svg | New rendered SVG for demo segment 02 (embedded in README). |
| docs/demo/03-four-configs.svg | New rendered SVG for demo segment 03. |
| docs/demo/04-nest-contrast.svg | New rendered SVG for demo segment 04. |
| docs/demo/05-fuzz-log.svg | New rendered SVG for demo segment 05. |
| docs/demo/06-hatch-gate.svg | New rendered SVG for demo segment 06. |
| docs/demo/07-one-command.svg | New rendered SVG for demo segment 07. |
| docs/demo/render_svg.py | New helper to render transcript text into SVG. |
| docs/demo/capture-segments.sh | New helper script to capture transcripts and generate SVGs. |
| docs/demo-script.md | New timed shot list + narration for recording the demo MP4. |
| DECISIONS.md | Add missing consequence for D012 and update D013 line count. |
| bench/methodology.md | Restore exact throughput floats to match measured artifacts. |
| bench/logs/run-darwin.txt | Redact absolute local paths from benchmark run log. |
| .gitignore | Ignore local dev/ and dev.zip agent context artifacts. |
Suppressed comments (1)
docs/evidence/freeze-regen/suite-default-zig.txt:9
- The freeze-regen transcript still records absolute local build paths in
cflags/link, which leaks a username and makes the artifact non-portable. Redact/sanitize these to repo-relative paths for committed evidence.
cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c
link: /Users/kavyabhand/Desktop/port/zig-out-default/lib/libtinyexpr.a /Users/kavyabhand/Desktop/port/zig-probe-stub.o -lm
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+7
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c | ||
| link: /Users/kavyabhand/Desktop/port/third_party/tinyexpr-c/tinyexpr.c -lm |
Comment on lines
+7
to
+8
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c | ||
| link: /Users/kavyabhand/Desktop/port/zig-out-default/lib/libtinyexpr.a /Users/kavyabhand/Desktop/port/zig-probe-stub.o -lm |
| @@ -0,0 +1,47 @@ | |||
| ld: warning: object file (/Users/kavyabhand/Desktop/port/zig-out-default/lib/libtinyexpr.a[2](libtinyexpr_zcu.o)) was built for newer 'macOS' version (15.1.1) than being linked (15.0) | |||
Comment on lines
+14
to
+18
| { | ||
| echo "$ $*" | ||
| # shellcheck disable=SC2068 | ||
| eval "$@" 2>&1 || true | ||
| } | tee "$SEG/${name}.txt" >/dev/null |
| echo "$ # C original: nested parentheses crash (host-dependent depth)" | ||
| echo "$ # Port: identical deep nest returns NestingTooDeep / te_compile NULL" | ||
| if [[ -f docs/evidence/repro/run-log-darwin.txt ]]; then | ||
| rg -n "crash|23764|Nesting|err=-1|SIGSEGV|first" docs/evidence/repro/run-log-darwin.txt | head -20 || true |
Comment on lines
+7
to
+8
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c -DTE_POW_FROM_RIGHT -DTE_NAT_LOG | ||
| link: /Users/kavyabhand/Desktop/port/third_party/tinyexpr-c/tinyexpr.c -lm |
Comment on lines
+1
to
+9
| ld: warning: object file (/Users/kavyabhand/Desktop/port/zig-out-pow/lib/libtinyexpr.a[2](libtinyexpr_zcu.o)) was built for newer 'macOS' version (15.1.1) than being linked (15.0) | ||
| === original suite transcript === | ||
| config: pow (zig-static) | ||
| git: e1c8ab6c2fb14461e7a53329e230547894952a1e | ||
| zig: 0.16.0 | ||
| compiler: Apple clang version 16.0.0 (clang-1600.0.26.6) | ||
| host: Darwin Kavyas-MacBook-Air-2.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:14 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T8103 arm64 | ||
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c -DTE_POW_FROM_RIGHT | ||
| link: /Users/kavyabhand/Desktop/port/zig-out-pow/lib/libtinyexpr.a /Users/kavyabhand/Desktop/port/zig-probe-stub.o -lm |
Comment on lines
+1
to
+9
| ld: warning: object file (/Users/kavyabhand/Desktop/port/zig-out-natlog/lib/libtinyexpr.a[2](libtinyexpr_zcu.o)) was built for newer 'macOS' version (15.1.1) than being linked (15.0) | ||
| === original suite transcript === | ||
| config: natlog (zig-static) | ||
| git: e1c8ab6c2fb14461e7a53329e230547894952a1e | ||
| zig: 0.16.0 | ||
| compiler: Apple clang version 16.0.0 (clang-1600.0.26.6) | ||
| host: Darwin Kavyas-MacBook-Air-2.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:14 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T8103 arm64 | ||
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c -DTE_NAT_LOG | ||
| link: /Users/kavyabhand/Desktop/port/zig-out-natlog/lib/libtinyexpr.a /Users/kavyabhand/Desktop/port/zig-probe-stub.o -lm |
Comment on lines
+1
to
+9
| ld: warning: object file (/Users/kavyabhand/Desktop/port/zig-out-pow_natlog/lib/libtinyexpr.a[2](libtinyexpr_zcu.o)) was built for newer 'macOS' version (15.1.1) than being linked (15.0) | ||
| === original suite transcript === | ||
| config: pow_natlog (zig-static) | ||
| git: e1c8ab6c2fb14461e7a53329e230547894952a1e | ||
| zig: 0.16.0 | ||
| compiler: Apple clang version 16.0.0 (clang-1600.0.26.6) | ||
| host: Darwin Kavyas-MacBook-Air-2.local 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:14 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T8103 arm64 | ||
| cflags: -Wall -Wshadow -O2 -I/Users/kavyabhand/Desktop/port/third_party/tinyexpr-c -DTE_POW_FROM_RIGHT -DTE_NAT_LOG | ||
| link: /Users/kavyabhand/Desktop/port/zig-out-pow_natlog/lib/libtinyexpr.a /Users/kavyabhand/Desktop/port/zig-probe-stub.o -lm |
Comment on lines
1
to
3
| === nm defined (Zig .a excerpt) === | ||
| 0000000000000000 T next_token | ||
| 000000000000062c T te_compile | ||
| 0000000000001880 T te_eval | ||
| 0000000000000975 T te_free | ||
| 0000000000000a2f T te_free_parameters | ||
| 00000000000005e7 T te_interp | ||
| 00000000000004d6 T te_print | ||
| === nm undefined te_* in smoke binary === | ||
| (none matching) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/evidence/self-audit.md) with dispositions.docs/demo-script.md(MP4 remains a human action).docs/writeup.mddraft and rootSUBMISSION.md.parser_leakDebugAllocator, D012/D013, methodology floats, path redaction.Suite assertion counts (unchanged)
Test plan