Conversation
helly25
force-pushed
the
feature/arena
branch
2 times, most recently
from
September 10, 2026 18:43
a4a5f67 to
3a59f0b
Compare
helly25
force-pushed
the
feature/arena
branch
from
September 10, 2026 19:28
3a59f0b to
fc1df1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the raw byte Arena and block-source layer required by SegmentedSequence and StringInterner. The implementation makes address stability, transactional failure, block growth, ownership transfer, and exception-disabled behavior explicit, while establishing a reproducible benchmark matrix rather than selecting performance-sensitive defaults by intuition.
This pull request is intentionally draft. It must not merge until the layout experiments are complete and validated JSON measurements exist for both Apple M5 Pro and AMD Zen 5.
AG;DR
MemoryBlockand theBlockSourceconcept.TryAllocateonly in exception-enabled builds because those standard APIs report exhaustion throughstd::bad_alloc.Arena<Source, ArenaOptions>with aligned stable byte allocation, transactional failure, geometric normal blocks, dedicated oversized blocks, O(1) block append, retained-blockReset, fullRelease, conditional address-preserving move/swap, and O(1) counters.memorycoverage category and baseline. The integrity checker now permits additive categories while continuing to reject changes to every existing category, top-level scope, and source exclusion. The Arena tests satisfy the enforced high boundaries without exclusions.mbo/memory/measurements.Validation at head
64123479c:bazel test //mbo/memory:arena_test //mbo/memory:block_source_testStill required before review/merge:
Portability: the API and implementation target C++20. Later-standard naming and semantics are followed where expressible in C++20. The raw-storage representation does not claim constexpr allocation in C++20.