Skip to content

Rename qlcplus-qml -> qlcplus5 on all platforms - #2089

Merged
mcallegari merged 4 commits into
masterfrom
v5linux
Aug 12, 2026
Merged

Rename qlcplus-qml -> qlcplus5 on all platforms#2089
mcallegari merged 4 commits into
masterfrom
v5linux

Conversation

@mcallegari

Copy link
Copy Markdown
Owner

Ensure no collisions on Linux. Only shared resources are fixtures, rgb scripts, gobos, etc.

@coveralls

coveralls commented Aug 7, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 35.313%. remained the same — v5linux into master

@jpue

jpue commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

I think the changes in this PR (keeping QLC+ 4 and 5 installations more separate) will pay off in the long run.

In the short term, however, this will probably generate a lot of activity and issue reports on the forums.
Especially on Windows, users are going to download the new version and simply install it over their existing installation, since this is how updates are carried out for most software (which do not have a built-in updater).
By doing so, the old qlcplus-qml.exe will likely remain in-place, whilst unrenamed .dll library files will be updated. If there now exists a link/shortcut to qlcplus-qml.exe used to start QLC+, it will either no longer work at all or crash unexpectedly/in weird places since parameters of calls to library functions have been changed in number and/or type.

Therefore, maybe a note should be added to the next release notes advising users to completely uninstall QLC+ and then reinstall it if they experience such problems.

In addition, whilst working on the build and deployment tooling, perhaps these changes (fad1e0f) could also be integrated, so that in QLC+ 5, the plugin configuration dialogues and the webaccess configuration page can also access the existing translations.

@mcallegari

Copy link
Copy Markdown
Owner Author

@jpue yes, I'll clearly state that from 5.2.x to 5.3.0 on Windows you need to uninstall first.

@edogawa23 I am worried about OBS builds. This change will basically split QLC+ into 3 packages on Debian: qlcplus (v4), qlcplus5 (v5) and qlcplus-data (common). We'll have to adjust the rules files, unless we want to keep building as a single package but the v4/v5 clash will stay.

@edogawa23

Copy link
Copy Markdown
Contributor

I'm not familiar with how the Windows installers are being built. I briefly looked at the Actions logs for this PR v4 and v5 Windows builds, but I can't take the time to study more carefully, currently.
So my question may seem silly, but can't we delete the previous installation's files while installing over or updating? AFAIK vlc, Ardour/Mixbus and many other software do it that way...

As for the debian package changes, I'd be more than happy to split common files into a -data subpackage, and would do the same for rpm distros and Arch. It will take a bit of work and time that I'm willing to spend, and would be able to do so in the next few weeks.

Generally I find it less than ideal that both the package from upstream debian and our OBS debian/ubuntu builds are generated from different dsc/rules/control etc. files than those in the QLC+ sources debian/ dir. I think there is an alternative way to build deb in OBS, and get rid of our debian.rules etc. duplicates in the OBS package and use the ones in debian/ directly, and again I am happy to take the time and find out how that's done properly.

@mcallegari
mcallegari merged commit d1d8f12 into master Aug 12, 2026
39 of 40 checks passed
@mcallegari
mcallegari deleted the v5linux branch August 12, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants