Rename qlcplus-qml -> qlcplus5 on all platforms - #2089
Conversation
Ensure no collisions on Linux. Only shared resources are fixtures, rgb scripts, gobos, etc.
|
I think the changes in this PR (keeping QLC+ 4 and 5 installations more separate) will pay off in the long run. In the short term, however, this will probably generate a lot of activity and issue reports on the forums. Therefore, maybe a note should be added to the next release notes advising users to completely uninstall QLC+ and then reinstall it if they experience such problems. In addition, whilst working on the build and deployment tooling, perhaps these changes (fad1e0f) could also be integrated, so that in QLC+ 5, the plugin configuration dialogues and the |
|
@jpue yes, I'll clearly state that from 5.2.x to 5.3.0 on Windows you need to uninstall first. @edogawa23 I am worried about OBS builds. This change will basically split QLC+ into 3 packages on Debian: qlcplus (v4), qlcplus5 (v5) and qlcplus-data (common). We'll have to adjust the rules files, unless we want to keep building as a single package but the v4/v5 clash will stay. |
|
I'm not familiar with how the Windows installers are being built. I briefly looked at the Actions logs for this PR v4 and v5 Windows builds, but I can't take the time to study more carefully, currently. As for the debian package changes, I'd be more than happy to split common files into a -data subpackage, and would do the same for rpm distros and Arch. It will take a bit of work and time that I'm willing to spend, and would be able to do so in the next few weeks. Generally I find it less than ideal that both the package from upstream debian and our OBS debian/ubuntu builds are generated from different dsc/rules/control etc. files than those in the QLC+ sources debian/ dir. I think there is an alternative way to build deb in OBS, and get rid of our debian.rules etc. duplicates in the OBS package and use the ones in debian/ directly, and again I am happy to take the time and find out how that's done properly. |
Ensure no collisions on Linux. Only shared resources are fixtures, rgb scripts, gobos, etc.