CV2-6724 : Sunset Check notification - #2447
Conversation
|
@caiosba FYI, I forwarded the emails to Jessie to get her feedback before merging the PR. |
caiosba
left a comment
caiosba
left a comment
There was a problem hiding this comment.
Sawy, while reviewing this, I was thinking about one thing... I don't think we should automatically send the download link to all admins. My suggestion is to send only the notification, and then send the download link only to users who request it (or even better, display the link on Check upon login), once we confirm that the requester is still a legit admin of that workspace.
My main concern is exposing the data more than necessary when probably only a few users will actually require it.
Let's discuss this with Jessie.
| @name = user.name | ||
| # Set subject based on type (notify or download) | ||
| subject_type = type == 'download' ? 'download' : 'notify' | ||
| subject = I18n.t("mail_sunset.#{subject_type}_subject", app_name: CheckConfig.get('app_name'), workspace: workspace) |
There was a problem hiding this comment.
Since the email body is not translated, I don't think we need to translate the title.
2 participants
Description
Send notification emails to workspace admins based on workspace usage, with separate messaging for high-usage and low-usage workspaces, using the copy from the Jessie shared documents.
References: CV2-6724
How to test?
Sent mails to Caio and Jessie
Checklist