fix(site): make mobile menu links navigate in Safari - #389
Merged
Merged
Conversation
The panel closed the <details> on click capture, which set the menu's `open` to false before the tapped link had navigated. Safari cancels a navigation whose target is hidden mid-click, so links appeared to do nothing; Chromium tolerated it, so the browser suite never caught it. Handle the click on the bubble phase instead and defer closing the menu to the next frame, so the link's navigation runs first and the panel is never hidden during the tap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwouFK3SEtQj2fDK3PAMXi
"Handing a board over" linked to the general community-administration guide. Send it to Server operations → Keep a recovery handover, the section that lists what a new operator needs to take a board on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwouFK3SEtQj2fDK3PAMXi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The panel closed the
Details
on click capture, which set the menu'sopento false before the tapped link had navigated. Safari cancels anavigation whose target is hidden mid-click, so links appeared to do nothing;
Chromium tolerated it, so the browser suite never caught it. Handle the click
on the bubble phase instead and defer closing the menu to the next frame, so
the link's navigation runs first and the panel is never hidden during the tap.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01EwouFK3SEtQj2fDK3PAMXi