ci: modernize the pipeline and bump the Go baseline - #1
Merged
Conversation
Port the proxycheck CI template into this repo, matching the change already made in gorequests: - go.yml moves to actions/checkout@v4 and actions/setup-go@v5, a 1.25/1.26 Go matrix across the existing three OSes, and codecov/codecov-action@v4 instead of the deprecated piped-curl uploader. The old 1.18/1.19 toolchains are no longer downloadable for current runners. - golangci-lint.yml is new, pinning golangci-lint v2.12.2 via golangci/golangci-lint-action@v7. - go.mod declares go 1.25. golangci-lint reports no issues, so no source change was needed. No API or behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the
proxycheckCI template into this repo, identical to the change madein
gorequestsso the wholefamily shares one pipeline shape.
go.yml—actions/checkout@v4,actions/setup-go@v5, matrix1.25/1.26across the existingubuntu/windows/macOSspread, andcodecov/codecov-action@v4replacingbash <(curl -s https://codecov.io/bash).golangci-lint.yml— new, pinning golangci-lintv2.12.2viagolangci/golangci-lint-action@v7.go.mod—go 1.18→go 1.25.README.md— a golangci-lint badge alongside the CI one.Why
The old matrix pinned Go
1.18/1.19, and those toolchains can no longer bedownloaded for current runners —
macOS-latestis arm64 now, and setup-go dieswith a 403 fetching
go1.18.10.darwin-arm64.tar.gzbefore any code is built.The action bump and the
go.modbump have to ship together; neither fixes italone.
Lint
golangci-lint runreports 0 issues on this module, so unlikegorequestsno source change was needed here.
Verification
Local, under the bumped
go.mod(Go 1.25 viaGOTOOLCHAIN=auto):go build ./...,go test -count=1 ./... -race,golangci-lint runclean. Thereal gate is this PR's 6 test jobs plus
lint.Note
The Codecov upload uses
fail_ci_if_error: false, so a missingCODECOV_TOKENdegrades to a no-op rather than reddening the build.
🤖 Generated with Claude Code