fix: reconnect real-click audit after page target replacement - #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks completion of #206 after its refreshed Frontend CI exposed the existing full-page navigation race.
What changed
Why
BragStack currently uses full-page internal navigation in several authenticated surfaces. The real-browser click audit was retrying Runtime.evaluate on the old detached target and could never recover, producing
Not attached to an active pageeven when the link itself was valid.Supersedes the insufficient closed attempt #195, which retried the same dead CDP session without reconnecting.
Merge gate
Merge only if Backend CI, Frontend CI, and Security CI are green on this exact head, the PR remains current/mergeable, and there are no unresolved review threads.