Shifter: Chain Utils: Add locator removal and fix single locator add offset - #649
Open
zebraed wants to merge 2 commits into
Open
Shifter: Chain Utils: Add locator removal and fix single locator add offset#649zebraed wants to merge 2 commits into
zebraed wants to merge 2 commits into
Conversation
Preserve child guides, rebuild display curves, group edits into one undo step, and correctly position additions for 1 locator chains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Extends Chain Utils with a way to shorten chains and fixes an existing
Add Locator bugfix.
chain. Only the tip is removed, child component guides are reparented to
the new chain end, the display curve is regenerated, and at least one
locator is always preserved.
locator, the new locator was created at the same position as the existing
one. The component root is now used as the direction source so the new
locator is placed correctly.
Testing Done
Maya2027 / Windows
display curve updated.
Click to view the testing video
testing_for_remove_add_locators.mp4
Related Issue(s)
N/A
Thank you.