Skip to content

fix(security): replace hardcoded database credentials with env vars - #36

Merged
miccy merged 2 commits into
v1.3.1from
fix-docker-compose-hardcoded-db-credentials-6384860232121466724
Aug 20, 2026
Merged

fix(security): replace hardcoded database credentials with env vars#36
miccy merged 2 commits into
v1.3.1from
fix-docker-compose-hardcoded-db-credentials-6384860232121466724

Conversation

@miccy

@miccy miccy commented Aug 20, 2026

Copy link
Copy Markdown
Owner
  • Replace hardcoded credentials in docker/docker-compose.yml with environment variable interpolation
  • Add documentation for database env vars in docker/README.md
  • Add automated test in tests/docker-config.test.ts to verify docker-compose configuration

- Replace hardcoded credentials in docker/docker-compose.yml with environment variable interpolation
- Add documentation for database env vars in docker/README.md
- Add automated test in __tests__/docker-config.test.ts to verify docker-compose configuration
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it skipped the latest review.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 167840ca55

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docker/docker-compose.yml
…s-6384860232121466724

Signed-off-by: Miccy <support@miccy.dev>
@miccy
miccy merged commit a8d0b6d into v1.3.1 Aug 20, 2026
3 checks passed
@miccy
miccy deleted the fix-docker-compose-hardcoded-db-credentials-6384860232121466724 branch August 20, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant