Bump superbuild Micro XRCE-DDS Agent pin to v3.0.1#271
Open
David-LP99 wants to merge 1 commit into
Open
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
v3.0.0 mishandles Fast DDS 3.x's DataWriter::write() return code (ReturnCode_t misread as bool), causing FastDDSReplier to treat successful service replies as failed writes. Fixed upstream in eProsima/Micro-XRCE-DDS-Agent#385. Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
David-LP99
force-pushed
the
5.0.3-vulcanexus
branch
from
fbf07d4 to
3c25869
Compare
David-LP99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the superbuild's Micro XRCE-DDS Agent pin from v3.0.0 to v3.0.1.
The v3.0.0 mishandles Fast DDS 3.x's DataWriter::write() return code (ReturnCode_t implicitly converted to bool), so FastDDSReplier::write() treats every successful write as a failure, which breaks service replies when built against Fast DDS 3.x (e.g. Vulcanexus).
Fixed upstream in eProsima/Micro-XRCE-DDS-Agent#385.