feat(search): expose page to match the API - #24
Conversation
The Google provider now takes page instead of start. CLI --page, MCP, and buildUrl follow that contract. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughSearch now supports selecting a result page. The option is validated in the MCP schema, serialized into search URLs, exposed in CLI and MCP help, documented, and covered by tests. ChangesSearch pagination
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR aligns search pagination across the API, CLI, MCP interface, and documentation; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant SearchClient
participant buildUrl
participant SearchRequest
SearchClient->>buildUrl: pass page option
buildUrl->>SearchRequest: add page query parameter when page > 1
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 7 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 32818281580Warning No base build found for commit Coverage: 76.298%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Summary
pageinstead ofstart(api@7acc621 /src/providers/google.js)buildUrlforwardspagewhen it is greater than 1--page, MCPpage, and docs match that contractTest plan
microlink search "the matrix" --page 2returns the second results pagemicrolink search --helplists--pageawait microlink.search('q', { page: 2 })hits?page=2pagequery paramMade with Cursor
Summary by CodeRabbit
New Features
pageoption.Documentation
.next().