fix(cli): fail cleanly on invalid extract --data - #25
Conversation
JSON.parse ran after the spinner started, so the FAIL footer could miss stderr when the process exited. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 32820309351Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.01%) to 76.287%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Summary
cli › fail footer prints FAIL on stderr--datawasJSON.parsed after the spinner started, so the FAIL line could miss stderr--datafirst and printInvalid --data JSONon the fail footerTest plan
microlink extract https://example.com --data '{'printsFAILandInvalid --data JSONon stderrpnpm exec ava test/cli.mjs -m "fail footer*"passesMade with Cursor