fix: correct source DOT guidance and ship-check failures - #356
Merged
Conversation
Correct the manager-child example so it teaches Graphviz-valid quoted dotted keys, with a guard that renders both the accepted and rejected forms. Harden ship_check so a git-status error remains an exit-zero dirty token and follows the existing dirty escalation edge. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Format only the D-336 test code introduced by the preceding source maintenance commit; no production bytes change. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
Provision the root guard job with the Graphviz executable required by its D-336 rendering witness. Keep the documented job prerequisites accurate. 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
The root guard job already installs Graphviz for the documentation render witness. Keep its comments accurate: the guard suite has no engine-module dependency, and Graphviz is an independent DOT-syntax prerequisite. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This was referenced Sep 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two source-side maintenance defects without changing the engine, pipeline model policy, workflow publication predicates, or any public API:
parent.dot, while documenting the runtime/parser distinction.ship_checkcommand sogit status/git ls-filesfailures cannot be treated as a clean or shipped tree; failures retain the existing dirty/escalate route.This is the source-side fix for Attractor #336 and the canonical source half of dot-runner #28. Dot-runner #28 is intentionally not auto-closed by this PR; its port must land separately. Dot-runner #62 is the next port maintenance item.
Verification checklist
specs/EXTENSIONS.mdentry is needed.tests/test_doc_consistency.py.Verification evidence
268 passed, 2 skipped.9focused tests passed.2335 passed, 237 skipped; the corresponding baseline was2326 passed, 237 skippedwith four pre-existing warnings. No engine files are changed here.Notes for reviewers
parent.dotwas already quoted and remains unchanged. The guard requires the quoted positive witness and a bare negative witness.Observations
None arose during this change.
CI prerequisite correction
The initial PR run failed in
Opinionated Guards (repo root)because the runner did not have thedotexecutable:test_manager_child_parser_note_rendering_witnesses_match_its_teachingraisedFileNotFoundError: [Errno 2] No such file or directory: 'dot'. The independent DOT Render Gate passed. The follow-up adds the existing Graphviz package prerequisite to the root guard job and updates the job comments/documentation; it does not alter the production README, DOT, or test logic.This follow-up is a CI-environment correction only. Root verification evidence remains
268 passed, 2 skipped; production behavior and the reviewed DOT/documentation/test changes are unchanged. No private artifacts or DTU logs are uploaded.