Merge Duplicate C#/.NET Sidebar Sections - #1632
Merge Duplicate C#/.NET Sidebar Sections#1632David Aniebo (Webmekanic) wants to merge 3 commits into
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
🟡 Changes recommended
The updated sidebar item labels diverge from established “label matches page title” nav consistency in the surrounding entries, and there’s an additional icons safelist change not accounted for in the PR’s stated scope.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Aspire integrations sidebar configuration to remove the duplicated “.NET / C#” section by merging its two Dotnet-by-path pages into the existing “C# and .NET” section, with updated item labels to distinguish them among the section entries.
Changes:
- Moves the Dotnet-by-path “Get started” and “AppHost setup” links into the existing “C# and .NET” sidebar group and removes the separate “.NET / C#” group.
- Adjusts the labels of the moved links to read distinctly within the merged section.
- Adds additional Starlight icon IDs to the icon safelist.
File summaries
| File | Description |
|---|---|
src/frontend/config/sidebar/integrations.topics.ts |
Merges the duplicate .NET/C# sidebar sections by relocating two Dotnet-by-path entries into the “C# and .NET” section and removing the redundant group. |
src/frontend/.starlight-icons/safelist.json |
Adds additional icon IDs to the safelist (kubernetes folder icons and a nix icon). |
Review details
Suppressed comments (1)
src/frontend/config/sidebar/integrations.topics.ts:1339
- This sidebar item label diverges from the page title (“Set up .NET / C# apps in the AppHost”). Most items in this file use the page title verbatim, so keeping the label aligned avoids confusion when users land on the page and see a different heading.
{
label: 'Set up C# apps by path in the AppHost',
slug: 'integrations/frameworks/dotnet/dotnet-host',
},
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "i-material-icon-theme:folder-docs", | ||
| "i-material-icon-theme:folder-docs-open", | ||
| "i-material-icon-theme:folder-kubernetes", | ||
| "i-material-icon-theme:folder-kubernetes-open", | ||
| "i-material-icon-theme:folder-plugin", |
There was a problem hiding this comment.
David Aniebo (@Webmekanic) - are these changes intentional?
There was a problem hiding this comment.
Eric Erhardt (@eerhardt) Good catch, that's unrelated to this PR. safelist.json is a build-generated cache that we commit and regenerate on every build. Running pnpm dev locally while testing the sidebar fix regenerated and staged that drift along with my actual change.
| { | ||
| label: 'Get started with apps by path', | ||
| slug: 'integrations/frameworks/dotnet/dotnet-get-started', | ||
| }, |
Summary
This PR merges the ".NET / C#" section (the
Aspire.Hosting.Dotnetby-path integration pages) into the single "C# and .NET" section, relabeling the two merged items ("Get started with apps by path" / "Set up C# apps by path in the AppHost") so they read distinctly next to the section's other entries. No slugs or page content changed, so no redirects are needed.Third-party links and affiliations
None
Validation
Closes #1630