Share signature verification across public-key and host-based auth paths - #161
Merged
David Obando (DavidObando) merged 1 commit intoAug 24, 2026
Conversation
Consolidate signature verification for public-key and host-based authentication requests in the C# and TypeScript servers into a single helper with an explicit contract: when verification does not succeed, the failure is reported and the caller returns immediately without raising the Authenticating event. This aligns both servers with the Go implementation, which already handled the two paths this way. Also correct host-based deserialization in the TypeScript PublicKeyRequestMessage, which read the public-key wire format regardless of method name, and populate PayloadWithoutSignature on the C# host-based read path so the verified transcript is correct if that path is enabled. Adds negative-path test coverage in both languages for authentication requests whose signature does not match the presented public key, across ECDSA P-256/P-384 and RSA SHA-256/SHA-512. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nagaraju Kotcharlakota (klvnraju)
approved these changes
Aug 24, 2026
juanpacostaaa
approved these changes
Aug 24, 2026
David Obando (DavidObando)
merged commit Aug 24, 2026
e65278d
into
microsoft:main
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate signature verification for public-key and host-based authentication requests in the C# and TypeScript servers into a single helper with an explicit contract: when verification does not succeed, the failure is reported and the caller returns immediately without raising the Authenticating event. This aligns both servers with the Go implementation, which already handled the two paths this way.
Also correct host-based deserialization in the TypeScript PublicKeyRequestMessage, which read the public-key wire format regardless of method name, and populate PayloadWithoutSignature on the C# host-based read path so the verified transcript is correct if that path is enabled.
Adds negative-path test coverage in both languages for authentication requests whose signature does not match the presented public key, across ECDSA P-256/P-384 and RSA SHA-256/SHA-512.