chore(deps): upgrade Azure Container Storage (ACSA) Arc extension to 2.12.0 - #786
Franco Ceballos Rastello (xThreeh) wants to merge 5 commits into
Conversation
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Thank you for your first contribution and for keeping the Azure Container Storage update focused. The 2.12.0 default is consistent across Bicep, Terraform, examples, and repository-local consumers, and the official release notes do not expose a conflict with this component.
Before we approve the workflow runs and complete the review, please update the PR description using the repository pull request template, and the Terraform doc formatting, as this will fail CI once we enable the workload runs.
Please rewrite the PR body using the repository PULL_REQUEST_TEMPLATE.md, complete every applicable section, link to issue #662.
Quick note: I also updated your PR title to the conventional commit message format.
| | terraform | >= 1.12.0, < 2.0 | | ||
| | azurerm | >= 4.8.0, < 5.0.0 | | ||
| | Name | Version | | ||
| | ---- | ------- | |
There was a problem hiding this comment.
The generated tables contain compact terraform-docs output instead of the repository-formatted aligned tables. Please run:
npm run tf-docs
npm run format-tables-checkThen commit the resulting aligned src/100-edge/109-arc-extensions/terraform/README.md.
There was a problem hiding this comment.
Done in 032d9c3 — the tables are aligned now. I re-ran Format-Markdown-Tables.ps1 -Check across the repo to confirm and it exits clean over all 1237 markdown files.
Worth noting for anyone hitting this later: running terraform-docs directly produces the compact tables. The aligned output comes from npm run tf-docs, which applies the table formatter afterwards. Version matters too — the docs drift check pins v0.20.0, and a newer local binary generates a different layout.
|
Katrien De Graeve (@katriendg) thanks for the review, and for fixing the title. All three points are addressed:
Validation run locally against this branch: |
kgmwang1
left a comment
There was a problem hiding this comment.
Thank you for this needed upgrade for ACSA
Description
Update the Azure Container Storage enabled by Azure Arc (ACSA) extension default version from
2.6.0to2.12.0in the109-arc-extensionscomponent.The Bicep and Terraform defaults now match, and the component README, the Terraform examples, and the generated Terraform documentation are updated accordingly. The module shape, the release train, and the extension
configurationSettingsare unchanged.Related Issue
Fixes #662
Type of Change
Implementation Details
Four files change, all inside
src/100-edge/109-arc-extensions:bicep/types.bicepcontainerStorageExtensionDefaults.release.version→2.12.0terraform/variables.tfarc_extensions.container_storage_extension.version→2.12.0README.mdterraform/README.mdterraform-docsoutputThe variable names the version-checker tooling depends on are untouched, per the note in #662.
Release train. The issue asks whether
trainneeds to move fromstabletopreviewfor this version. It does not. ACSA releases carried an explicit suffix while they were preview builds (2.1.0-preview,1.2.0-preview); every release from2.2.1onward, including2.12.0, ships without one. The product as a whole is still in public preview, but that is orthogonal to the extension release train, and2.6.0already usedstable.Extension settings. No
configurationSettingskey consumed by this component changed between2.6.0and2.12.0.disk_storage_class,fault_tolerance_enabled, anddisk_mount_pointare all still valid, so no schema migration is required here.Testing Performed
terraform fmt,terraform validate,tflint,az bicep build, and aterraform-docsdrift check, all run locally against this branch.No regression test is included: this changes a default version value and adds no new logic or module surface to assert against.
Validation Steps
Run from
src/100-edge/109-arc-extensions/terraform:terraform fmt -check -recursive . terraform init -backend=false terraform validate tflintRun from
src/100-edge/109-arc-extensions/bicep:az bicep build --file main.bicep --stdout > /dev/nullThen confirm
2.12.0is the default inbicep/types.bicep,terraform/variables.tf, and both READMEs, and that no2.6.0reference to this extension remains in the component.Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeTwo boxes are deliberately left unchecked. The repository test suite was not executed end to end, only the linters and validators listed above. And
az bicep formatreports a single trailing-blank-line difference inbicep/types.bicepthat is already present onmain; normalising it here would add unrelated noise to the diff.Security Review
This PR touches none of the security-sensitive paths listed in the template (
SECURITY.md,src/000-cloud/010-security-identity/,deploy/).2.12.0adds support for the localhost token endpoint, which lets the identity adapter sidecar run without elevated network privileges. That is opt-in and is not enabled by this change.Additional Notes
None.