chore(build): isolate Checkov 3.3.16 upgrade - #797
Draft
Marcel Bindseil (bindsi) wants to merge 1 commit into
Draft
Marcel Bindseil (bindsi) wants to merge 1 commit into
Marcel Bindseil (bindsi) wants to merge 1 commit into
Conversation
🔒 - Generated by Copilot
Dependency ReviewThe following issues were found:
Vulnerabilitiesrequirements.txt
Only included vulnerabilities with severity high or higher. OpenSSF Scorecard
Scanned Files
|
29 tasks
Marcel Bindseil (bindsi)
added a commit
that referenced
this pull request
Sep 9, 2026
# Pull Request ## Description Updated GitPython to 3.1.61, python-hcl2 to 8.1.3, NumPy to 2.5.2 and python-dotenv to 1.2.3. Split the Checkov upgrade into draft #797, retaining Checkov 3.2.531 here and removing its newly introduced ecdsa dependency. Added commit b13917f to fix the remaining high-severity findings blocking Security Scan. Updated all locked js-yaml v4 copies to 4.3.2 and the docs dependencies to svgo 3.3.5, qs 6.16.0, colord 2.10.0 and joi 17.13.7. No scan thresholds, suppressions, permissions, or workflow failure handling were changed. ## Related Issue Relates to draft #797, which keeps the Checkov-only update blocked pending advisory remediation. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Blueprint modification or addition - [ ] Component modification or addition - [ ] Documentation update - [ ] CI/CD pipeline change - [x] Other (please describe): Python and npm dependency security maintenance ## Implementation Details The Checkov removal was published as additive commit bfa7d59. The CI fix changes four npm lockfiles (root tools, docs, markdown link checker, chat application) and the docs override floors. Lockfile package sets and root metadata were preserved; only the five identified npm packages changed. Checkov 3.2.531 requires asteval==1.0.6. Its two medium-severity findings remain visible, below the unchanged high-severity Grype failure threshold. Upgrading asteval independently would violate Checkov's declared requirements, so this PR does not force an incompatible dependency or add an exception. ## Testing Performed - [ ] Terraform plan/apply - [ ] Blueprint deployment test - [x] Unit tests - [ ] Integration tests - [ ] Bug fix includes regression test (see [Test Policy](docs/contributing/testing-validation.md)) - [x] Manual validation - [x] Other: dependency resolution, clean installs, builds and vulnerability scan Validation on the CI-fix tree: - Grype 0.116.0 passed using the existing .grype.yaml high-severity policy; only the two medium asteval findings remained. Local generated node_modules/.git/target directories were excluded to represent a clean CI checkout. Hosted CI uses its pinned scanner version and remains authoritative. - Docs: clean npm ci, 3 suites / 15 tests passed, TypeScript typecheck passed, production build passed. Existing broken-link warnings remain. - Chat application: clean npm ci, 6 suites / 38 tests passed, server/client production build passed. - Root and markdown link checker: clean npm ci and local YAML/XML/link-checker smoke checks passed. - Structured lockfile assertions confirmed patched dependency versions, unchanged package sets/root metadata and no local filesystem dependencies. git diff --check and editor diagnostics passed. - Earlier Python validation: root Linux x86_64 / Python 3.12 resolution and hash-enforced sync passed for 96 packages, uv pip check passed, Checkov startup returned 3.2.531, and ecdsa was removed. Unchanged ROS2 split files previously passed hash-enforced installation and NumPy/dotenv smoke checks. Fresh hosted CI was triggered by the latest push; no all-green hosted result is claimed yet. No cloud deployment or full ROS2 integration build was run. ## Validation Steps 1. Verify Checkov remains at 3.2.531 and ecdsa is absent. 2. Verify all js-yaml v4 copies are at least 4.3.2 and docs dependencies meet the patched override floors. 3. Require passing Dependency Scan, Security Scan and PR Validation Gate on the final up-to-date head before merging. The user will perform the merge. ## Checklist - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] All new and existing tests passed - [ ] I have run `terraform fmt` on all Terraform code - [ ] I have run `terraform validate` on all Terraform code - [ ] I have run `az bicep format` on all Bicep code - [ ] I have run `az bicep build` to validate all Bicep code - [x] I have checked for any sensitive data/tokens that should not be committed - [ ] Lint checks pass (run applicable linters for changed file types) ## Security Review - [x] No credentials, secrets, or tokens are hardcoded or logged - [ ] RBAC and identity changes follow least-privilege principles - [x] No new network exposure or public endpoints introduced without justification - [x] Dependency additions or updates have been reviewed for known vulnerabilities - [ ] Container image changes use pinned digests or SHA references No new vulnerability suppressions or reduced enforcement. The two medium asteval advisories remain disclosed; #797 retains the separately blocked ecdsa/Checkov update. ## Additional Notes #797 remains draft and was not changed by this CI fix. No branches were rebased or force-pushed and no PR was merged. ## Screenshots (if applicable) Not applicable. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcel Bindseil <marcelbindseil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Isolated the Checkov upgrade from #794 so the other four Python dependency updates can proceed independently. Updated Checkov from locked version 3.2.531 to 3.3.16, bc-detect-secrets from 1.5.47 to 1.5.50, and added Checkov's ecdsa 0.19.2 dependency.
Related Issue
Relates to #794. No separate issue is linked.
Type of Change
Implementation Details
Changed only root requirements.in and requirements.txt. Retained the existing dependency hashes from the original reviewed Checkov update. Left GitPython, python-hcl2, NumPy, dotenv and all ROS2 requirements unchanged relative to main.
The inspected Checkov consumer performs public-key signature verification, which the advisory explicitly excludes. Exploitable signing behavior has not been demonstrated. The dependency nevertheless fails the repository's security policy; this draft tracks the update without suppressing that policy.
Testing Performed
The original grouped update's package hashes, hash-enforced installation, dependency consistency and Checkov startup were reviewed previously. The independent branch was checked for resolution and exact scope; its security gate is expected to reject ecdsa. No deployment or cloud integration test was run.
Validation Steps
Checklist
Security Review
Known blocking advisory: GHSA-wj6h-64fc-37mp. The checked dependency-review item means the advisory was examined, not that it was accepted or remediated.
Additional Notes
Keep this PR in draft. #794 retains GitPython 3.1.61, python-hcl2 8.1.3, NumPy 2.5.2 and python-dotenv 1.2.3 without this Checkov upgrade. No merge is requested for the Checkov-only draft.
Screenshots (if applicable)
Not applicable.