Skip to content

[DevOps] Add missing comment triggers to Needs: Attention policy #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flanakin wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −0
Open

[DevOps] Add missing comment triggers to Needs: Attention policy #2079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d91de
Add missing comment triggers to Needs: Attention policy
flanakin Apr 3, 2026
b44a34e
Restore issueAuthor guards on pulls-03-feedback triggers
flanakin Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/policies/pulls-03-feedback.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ configuration:
reviewState: Commented
- isActivitySender:
issueAuthor: False
- and:
- payloadType: Issue_Comment
- isAction:
action: Created

Copilot AI Apr 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding payloadType: Issue_Comment here makes author comments like #needs-review match this policy too. That conflicts with .github/policies/pulls-04-respond.yml (which uses #needs-review to remove Needs: Attention 👋 and re-add Needs: Review 👀): the #needs-review comment will now also trigger this policy and can immediately re-add Needs: Attention 👋, making #needs-review ineffective. Exclude #needs-review from this policy (or split tasks so Issue_Comment labeling doesn’t run for that command) to avoid the label ping-pong.

Suggested change
action: Created
action: Created
- not:
commentContains:
pattern: '#needs-review'

Copilot uses AI. Check for mistakes.

@flanakin flanakin Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [AI][Claude Code] ✅ Implemented

Resolved via the consolidated fix from MSBrett's review — restored isActivitySender: issueAuthor: False on all triggers in pulls-03-feedback.yml, including the new Issue_Comment branch. This avoids the #needs-review conflict at the source instead of excluding the specific string.

Comment on lines +35 to +38

Copilot AI Apr 3, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Issue_Comment triggering this task and an unconditional addReply in the then, the bot’s own reply comment is likely an Issue_Comment (action: Created) and can re-trigger this same policy, potentially creating a self-reply loop (and repeated label/assignment churn). Add a guard to ignore comments authored by the policy bot (or restructure into separate tasks so addReply is not executed for Issue_Comment events).

Copilot uses AI. Check for mistakes.

@flanakin flanakin Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [AI][Claude Code] ✅ Implemented

Same fix resolves this — the Issue_Comment trigger now requires issueAuthor: False, so the bot's own addReply (posted as the repo's policy bot, not the PR author) won't itself re-trigger the rule via the author-comment path, and non-author comments no longer risk a thrash loop against pulls-04-respond.yml.

- isActivitySender:
issueAuthor: False
- not:
targetsBranch:
branch: main
Expand Down