chore: update generator to stop using "export *" - #33379
Merged
Oleksandr Fediashov (layershifter) merged 1 commit intoDec 7, 2024
Merged
Conversation
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/fix-barrel-files-generator
branch
from
December 2, 2024 10:09
2dc4d76 to
03722fc
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Oleksandr Fediashov (layershifter)
marked this pull request as ready for review
December 2, 2024 10:28
Oleksandr Fediashov (layershifter)
requested a review
from a team
as a code owner
December 2, 2024 10:28
Oleksandr Fediashov (layershifter)
changed the title
Tudor Popa (tudorpopams)
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR updates the components' generator to output exact exports instead of
export *in barrel files.This will improve performance of current compiler in Griffel and will unblock the future one, see microsoft/griffel#621.