chore: remove usage of "export *" [part 2] - #33384
Merged
Oleksandr Fediashov (layershifter) merged 1 commit intoDec 9, 2024
Merged
Conversation
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
from
December 2, 2024 14:20
aa96216 to
2c2f470
Compare
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
6 times, most recently
from
December 2, 2024 14:50
c16412f to
2c69789
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
2 times, most recently
from
December 2, 2024 15:12
8ca88a4 to
13a23a8
Compare
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
2 times, most recently
from
December 2, 2024 15:51
641e669 to
b208264
Compare
Oleksandr Fediashov (layershifter)
marked this pull request as ready for review
December 2, 2024 16:15
Dmytro Kirpa (dmytrokirpa)
approved these changes
Dec 4, 2024
Makoto Morimoto (khmakoto)
approved these changes
Dec 5, 2024
Makoto Morimoto (khmakoto)
approved these changes
Dec 7, 2024
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
from
December 9, 2024 09:49
b31250d to
4b282df
Compare
Oleksandr Fediashov (layershifter)
force-pushed
the
chore/remove-export-star-2
branch
from
December 9, 2024 09:50
4b282df to
1a46a5a
Compare
ling1726
approved these changes
Dec 9, 2024
Oleksandr Fediashov (layershifter)
deleted the
chore/remove-export-star-2
branch
December 9, 2024 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
export *is used in a lot of files.New Behavior
No API changes
export *is replaced with exact exports. This will improve performance of current compiler in Griffel and will unblock the future one, see microsoft/griffel#621.Note: I used autofix via
--fixon ESLint, so some other things were fixed (unused ESLint supressions, etc.).