Forward live audio language through SDK adapters - #1138
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot started reviewing on behalf of
Baiju Meswani (baijumeswani)
September 22, 2026 22:06
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The adapters consistently forward the lowercase option and focused tests cover both configured and default behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Forwards live-audio language settings through legacy SDK adapters to native request options while preserving default behavior.
Changes:
- Adds language forwarding in C#, JavaScript, Python, and Rust.
- Adds focused adapter tests for forwarding and unset-language behavior.
- Updates real-model streaming tests to specify English explicitly.
| File | Description |
|---|---|
sdk_v2/rust/tests/integration/live_audio_test.rs |
Exercises language forwarding in Rust integration testing. |
sdk_v2/rust/src/openai/live_audio_session.rs |
Applies snapshotted language to native request options. |
sdk_v2/python/test/unit/test_live_audio_session.py |
Verifies Python language forwarding and snapshot behavior. |
sdk_v2/python/test/integration/test_live_audio.py |
Uses the streaming model fixture and explicit language. |
sdk_v2/python/src/foundry_local_sdk/openai/live_audio_session.py |
Forwards language through RequestOptions. |
sdk_v2/js/test/live-audio-session-adapter.test.ts |
Tests set and unset language handling. |
sdk_v2/js/test/live-audio-client.test.ts |
Adds language to real-model streaming coverage. |
sdk_v2/js/src/openai/liveAudioSession.ts |
Passes the captured language to the request. |
sdk_v2/cs/test/FoundryLocal.Tests/LiveAudioTranscriptionTests.cs |
Tests request construction and integration forwarding. |
sdk_v2/cs/src/OpenAI/LiveAudioTranscriptionClient.cs |
Creates requests with snapshotted language options. |
sdk_v2/cpp/test/sdk_api/streaming_audio_test.cc |
Exercises native streaming with a language option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmehta001
approved these changes
Sep 22, 2026
Baiju Meswani (baijumeswani)
enabled auto-merge (squash)
September 22, 2026 22:36
Baiju Meswani (baijumeswani)
deleted the
baijumeswani/fix-asr-models
branch
September 22, 2026 23:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #1064 added native handling for the live audio
languageoption. However, the legacy SDK live audio sessions did not pass their language setting to the native request, so the native resolver could not use it.This change forwards the language setting from the C#, JavaScript, Python, and Rust SDKs. The value is captured when the session starts and is passed as the lowercase
languagerequest option. When no language is set, the existing default behavior is unchanged.The change also adds focused tests for the SDK adapters and updates the real-model streaming tests to exercise language forwarding in C++, C#, JavaScript, Python, and Rust.