Skip to content

docs(customization): sync devcontainer example with devcontainer.json - #2885

Closed
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
microsoft:mainfrom
MohammedAlkindi:docs/sync-environment-devcontainer-example
Closed

docs(customization): sync devcontainer example with devcontainer.json#2885
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
microsoft:mainfrom
MohammedAlkindi:docs/sync-environment-devcontainer-example

Conversation

@MohammedAlkindi

Copy link
Copy Markdown
Contributor

Description

The "Customizing for Your Team" example omitted "pnpmVersion": "none" and "installTools": false, which #2874 added to the real .devcontainer/devcontainer.json to stop network handshake failures on unused optional downloads. Copying the snippet reintroduced what that change fixed. The example now matches the real file for the node:1 and python:1 features.

Related Issue(s)

Closes #2881

Type of Change

  • Documentation update

Testing

npm run lint:md: 492 files, 0 issues. npm run spell-check: 799 files, 0 issues. Both repo-wide, exit 0.

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)

Required Local Checks

  • Spell checking: npm run spell-check
  • Local validation aggregate: npm run validate:local
  • Documentation validation (if docs changed): npm run validate:docs
  • Link validation: npm run lint:md-links

The unchecked commands need pwsh, absent on this machine, so they were not run.

Security Considerations

  • This PR does not contain any sensitive or NDA information

🤖 Generated with Claude Code

The Customizing for Your Team example omitted the pnpmVersion and installTools keys that microsoft#2874 added to the real .devcontainer/devcontainer.json, so following the doc reintroduced the network handshake failures that change fixed.

Closes microsoft#2881
@MohammedAlkindi

Copy link
Copy Markdown
Contributor Author

Duplicate of #2884, which makes the same change and also bumps ms.date. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update environment.md example for pnpmVersion/installTools devcontainer settings

1 participant