Skip to content

Fix error logging for invalid content types - #24

Open
Bjarke Vad Andersen (bjarkevad) wants to merge 1 commit into
microsoft:mainfrom
bjarkevad:patch-1
Open

Fix error logging for invalid content types #24
Bjarke Vad Andersen (bjarkevad) wants to merge 1 commit into
microsoft:mainfrom
bjarkevad:patch-1

Conversation

@bjarkevad

Copy link
Copy Markdown

contentType does not exist, the correct variable is content_type.

…istry

`contentType` does not exist, the correct variable is `content_type`.
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Bjarke Vad Andersen (@bjarkevad)
Thanks for the contribution!
The issue also exists in the serialization writer registry factory, can you correct this as well?
https://github.com/microsoft/kiota-abstractions-ruby/blob/main/lib/microsoft_kiota_abstractions/serialization/serialization_writer_factory_registry.rb

Can you also add an entry to the changelog (new patch version, today's date, add a changed section)?
And bump the version in the version constant?
This will help ensure a swift release.
Thanks!

@baywet

Copy link
Copy Markdown
Member

Hi Bjarke Vad Andersen (@bjarkevad)
Gentle reminder on the topic. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants