fix(ruby): add composed type support and disable inner classes for wrappers

CHANGELOG.md

@@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Fixed defaults primitive default-value handling during code generation for all languages
+- Ruby: added composed type (union/intersection) support to the factory, serializer and deserializer bodies, and stopped emitting composed type wrappers as inner classes. Un-suppresses the Twitter integration test. [kiota-abstractions-ruby#73](https://github.com/microsoft/kiota-abstractions-ruby/issues/73) [#1816](https://github.com/microsoft/kiota/issues/1816)
+- Ruby: `initialize` is now a reserved name. An API member called `initialize` previously generated a second `def initialize`, redefining the constructor; it is now escaped.
+- Ruby: removed the blank line emitted at the start of every generated class body.
+- Ruby: moved the runtime gem dependencies to 0.19.0, the first release able to serialize a primitive composed type member and to tell which member a payload holds.
 - Fixed plugin manifest generation to omit unsafe `oauth_card_path` file references that could resolve outside the plugin package.
 - Bumped `Microsoft.OpenApi` and `Microsoft.OpenApi.YamlReader` to 3.10.0.
 - Numeric scalar unions with a format (e.g. `type: ["integer", "string"]` with `format: int32`, as emitted by ASP.NET Core's OpenAPI 3.1 generator under System.Text.Json's default `JsonNumberHandling.AllowReadingFromString`) now map to the numeric type instead of degrading to `UntypedNode`. [#6541](https://github.com/microsoft/kiota/issues/6541)

it/config.json

@@ -146,10 +146,6 @@
   },
   "https://api.twitter.com/2/openapi.json": {
     "Suppressions": [
-      {
-        "Language": "ruby",
-        "Rationale": "https://github.com/microsoft/kiota-abstractions-ruby/issues/73"
-      },
       {
         "Language": "dart",
         "Rationale": "dart analyze fails on unnecessary_null_comparison for primitive binary union media models - https://github.com/microsoft/kiota/issues/7997"

it/ruby/.rubocop.yml

@@ -131,6 +131,11 @@ Naming/VariableNumber:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
+# Composed type factories, serializers and deserializers branch once per union member,
+# so their complexity tracks the arity of the union rather than any avoidable nesting
+Metrics/PerceivedComplexity:
+  Enabled: false
+
 # Generated factory methods may just delegate to super
 Lint/UselessMethodDefinition:
   Enabled: false

it/ruby/Gemfile

@@ -11,10 +11,10 @@ gem "rspec", "~> 3.0"
 
 gem "rubocop", "~> 1.21"
 
-gem "microsoft_kiota_abstractions", "~> 0.15.1"
+gem "microsoft_kiota_abstractions", "~> 0.19.0"
 
-gem "microsoft_kiota_faraday", "~> 0.16.0"
+gem "microsoft_kiota_faraday", "~> 0.19.0"
 
-gem "microsoft_kiota_serialization_json", "~> 0.10.0"
+gem "microsoft_kiota_serialization_json", "~> 0.19.0"
 
-gem "microsoft_kiota_authentication_oauth", "~> 0.9.0"
+gem "microsoft_kiota_authentication_oauth", "~> 0.19.0"

src/Kiota.Builder/Refiners/RubyRefiner.cs

@@ -43,7 +43,8 @@ public override Task RefineAsync(CodeNamespace generatedCode, CancellationToken
             UpdateReferencesToDisambiguatedClasses(generatedCode, classesToDisambiguate, suffix);
             ConvertUnionTypesToWrapper(generatedCode,
                 _configuration.UsesBackingStore,
-                static s => s
+                static s => s,
+                false
             );
             var reservedNamesProvider = new RubyReservedNamesProvider();
             CorrectNames(generatedCode, s =>

src/Kiota.Builder/Refiners/RubyReservedNamesProvider.cs

@@ -45,6 +45,8 @@ public class RubyReservedNamesProvider : IReservedNamesProvider
         "BaseRequestBuilder",
         "ObjectId",
         "object_id",
+        // Object protocol: a generated member of this name would redefine the constructor
+        "initialize",
     });
     public HashSet<string> ReservedNames => _reservedNames.Value;
 }

src/Kiota.Builder/Writers/Ruby/CodeClassDeclarationWriter.cs

@@ -57,7 +57,8 @@ public override void WriteCodeElement(ClassDeclaration codeElement, LanguageWrit
         if (codeElement.Parent is CodeClass parentClass)
             conventions.WriteShortDescription(parentClass, writer);
         writer.StartBlock($"class {codeElement.Name.ToFirstCharacterUpperCase()}{derivation}");
-        var mixins = !codeElement.Implements.Any() ? string.Empty : $"include {codeElement.Implements.Select(static x => x.Name).Aggregate(static (x, y) => x + ", " + y)}";
-        writer.WriteLine($"{mixins}");
+        // writing an empty mixin line would leave a blank (indent-only) first line in the class body
+        if (codeElement.Implements.Any())
+            writer.WriteLine($"include {codeElement.Implements.Select(static x => x.Name).Aggregate(static (x, y) => x + ", " + y)}");
     }
 }