Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/certs/certs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ func Test_CACertsRenewVerifySameKey(t *testing.T) {

clientCerts = [][]byte{certClient1.Raw}
if err := caAuth.VerifyClientCertificate(clientCerts); err != nil {
t.Errorf("failed to verify certificate: " + err.Error())
t.Errorf("failed to verify certificate: %s", err.Error())
}
if _, err = tls.X509KeyPair(EncodeCertPEM(certClient1), EncodePrivateKeyPEM(keyClient)); err != nil {
t.Errorf("Error Verifying key and cert: %s", err.Error())
Expand Down Expand Up @@ -640,7 +640,7 @@ func Test_CACertsRenewVerifySameKey(t *testing.T) {

clientCerts = [][]byte{certClient2.Raw}
if err := caAuth.VerifyClientCertificate(clientCerts); err != nil {
t.Errorf("failed to verify certificate: " + err.Error())
t.Errorf("failed to verify certificate: %s", err.Error())
}
if _, err = tls.X509KeyPair(EncodeCertPEM(certClient2), EncodePrivateKeyPEM(keyClient)); err != nil {
t.Errorf("Error Verifying key and cert: %s", err.Error())
Expand Down
2 changes: 1 addition & 1 deletion pkg/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ testArray:
tmpData := SampleStruct{}
err := LoadYAMLConfig(tmpString, &tmpData)
if err != nil {
t.Errorf("Failed to load Yaml Config" + err.Error())
t.Errorf("Failed to load Yaml Config: %s", err.Error())
}
}
func Test_PrintYAML(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/redact/redact_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ func TestRedactErrorJsonSensitiveField(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
val := reflect.ValueOf(tt.inputJson)
err := fmt.Errorf(tt.inputError)
err := fmt.Errorf("%s", tt.inputError)

redactErrorJsonSensitiveField(val, &err)

assert.Equal(t, fmt.Errorf(tt.expectedError), err)
assert.Equal(t, fmt.Errorf("%s", tt.expectedError), err)
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/status/status_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func simulateStackTraceError(err error, desc string) error {
}

func returnFakeError(err error, desc string) error {
return errors.Wrapf(err, desc)
return errors.Wrapf(err, "%s", desc)
}

func TestSetErrorWithStackTraceExcludesStackTrace(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/validations/proxy_validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func ValidateProxyURL(proxyURL string) (*url.URL, error) {
parsedURL, err := url.ParseRequestURI(proxyURL)

if err != nil {
return nil, errors.Wrapf(errors.InvalidInput, err.Error())
return nil, errors.Wrapf(errors.InvalidInput, "%s", err.Error())
}

// Check if url scheme is http or https
Expand Down Expand Up @@ -54,7 +54,7 @@ func TestProxyUrlConnection(parsedURL *url.URL, certContent string, getRequestUr
// Test the HTTP GET request
response, err := client.Get(getRequestUrl)
if err != nil {
return errors.Wrapf(errors.InvalidInput, err.Error())
return errors.Wrapf(errors.InvalidInput, "%s", err.Error())
} else {
defer response.Body.Close()
fmt.Println("Connected successfully to the proxy server")
Expand Down
2 changes: 1 addition & 1 deletion pkg/validations/proxy_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ func Test_ValidateProxyURL(t *testing.T) {
func Test_TestProxyUrlConnection(t *testing.T) {
caCert, _, err := certs.GenerateClientCertificate("ValidCertificate")
if err != nil {
t.Fatalf(err.Error())
t.Fatalf("%s", err.Error())
}
certBytes := certs.EncodeCertPEM(caCert)
caCertString := string(certBytes)
Expand Down