Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Xavier Dupré (xadupre)
approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Generated kernel documentation is stale, backend exclusions remain, and the DirectML fallback boundary lacks targeted coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds CPU support for signed BitShift in opset 28 while preserving earlier unsigned behavior.
Changes:
- Implements defined signed shift and saturation semantics.
- Splits CPU registrations and enables uint16.
- Caps DirectML support at opset 27 and expands tests.
File summaries
| File | Description |
|---|---|
onnxruntime/core/providers/cpu/math/element_wise_ops.cc |
Implements safe shifts and registrations. |
onnxruntime/core/providers/cpu/cpu_execution_provider.cc |
Registers opset-specific CPU kernels. |
onnxruntime/core/providers/dml/DmlExecutionProvider/src/AbiCustomRegistry.cpp |
Caps DirectML BitShift support. |
onnxruntime/test/providers/cpu/math/element_wise_ops_test.cc |
Adds signed and unsigned tests. |
onnxruntime/test/onnx/TestCase.cc |
Enables uint16 C++ backend tests. |
Review details
Suppressed comments (1)
onnxruntime/core/providers/cpu/math/element_wise_ops.cc:1394
- This
elseis unnecessary after the signed branch returns and violates the repository'sAGENTS.md:108no-else-after-returnconvention.
} else {
return result;
- Files reviewed: 5/5 changed files
- Comments generated: 5
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mirounga
merged commit Sep 21, 2026
81b968d
into
justinchuby-onnx-1-23-opset-28-base
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ONNX BitShift opset 28 support for signed
int8,int16,int32, andint64tensors while preserving unsigned support.0/-1saturation semantics.uint16kernel.Stacked on #32359.
Validation
onnxruntime_provider_testbuild is currently blocked by the base branch's unrelatedtensorprotoutils.hnumeric datatype map static assertion after the ONNX c78026fa update. The failure occurs across unrelated provider translation units before BitShift tests can link.