Support opset 28 SwiGLU and log reductions - #32381
Open
Justin Chu (justinchuby) wants to merge 3 commits into
Open
Justin Chu (justinchuby) wants to merge 3 commits into
Justin Chu (justinchuby) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ase' into justinchuby-opset-28-function-validation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwiGLU-28, including the vectorized MLAS SiLU path for the default alphaReduceLogSumandReduceLogSumExpregistrations at opset 28 across CPU, CUDA, JS, and WebGPU so v28 advertises only supported float types while opsets 18-27 retain integer supportThe native SwiGLU kernel is narrowly required because the upstream body expands to
Swish-24, which ORT cannot safely re-expand at an outer opset 28 after referenced primitive schemas changed; without the kernel, session initialization fails with noSwish(24)implementation.Validation
onnxruntime_test_allbuildonnxruntime_provider_testbuildFunctionTest.SwiGLUOpset28*: 2 passedReductionOpTest.ReduceLogOps_Opset*: 4 passedgit diff --checkStacked on #32359 /
justinchuby-onnx-1-23-opset-28-baseat66026459a8a7553a04dfcb5798ece21f9a4ba0b1.