Skip to content

Support opset 28 SwiGLU and log reductions - #32381

Open
Justin Chu (justinchuby) wants to merge 3 commits into
justinchuby-onnx-1-23-opset-28-basefrom
justinchuby-opset-28-function-validation
Open

Justin Chu (justinchuby) wants to merge 3 commits into
justinchuby-onnx-1-23-opset-28-basefrom
justinchuby-opset-28-function-validation

Conversation

@justinchuby

Copy link
Copy Markdown
Contributor

Summary

  • add a CPU float/double kernel for ONNX SwiGLU-28, including the vectorized MLAS SiLU path for the default alpha
  • validate the upstream function body can be loaded and explicitly inlined, plus shape inference and numerical behavior
  • split ReduceLogSum and ReduceLogSumExp registrations at opset 28 across CPU, CUDA, JS, and WebGPU so v28 advertises only supported float types while opsets 18-27 retain integer support
  • update generated operator registration documentation

The native SwiGLU kernel is narrowly required because the upstream body expands to Swish-24, which ORT cannot safely re-expand at an outer opset 28 after referenced primitive schemas changed; without the kernel, session initialization fails with no Swish(24) implementation.

Validation

  • Windows RelWithDebInfo onnxruntime_test_all build
  • Windows RelWithDebInfo onnxruntime_provider_test build
  • FunctionTest.SwiGLUOpset28*: 2 passed
  • ReductionOpTest.ReduceLogOps_Opset*: 4 passed
  • clang-format and git diff --check
  • independent GPT-5.6 Terra review: no remaining findings

Stacked on #32359 / justinchuby-onnx-1-23-opset-28-base at 66026459a8a7553a04dfcb5798ece21f9a4ba0b1.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ase' into justinchuby-opset-28-function-validation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant