Fix duplicate script_params in the AzureML BERT notebook - #32532
Open
Yanze (David) Wu (David-Wu1119) wants to merge 1 commit into
Open
Yanze (David) Wu (David-Wu1119) wants to merge 1 commit into
Yanze (David) Wu (David-Wu1119) wants to merge 1 commit into
Conversation
The PyTorch estimator cell passes script_params twice, the second time
as a `{...}` placeholder:
script_params={'--output-dir': './outputs'},
...
script_params = {...},
Python rejects a repeated keyword argument at compile time, so the cell
raises
SyntaxError: keyword argument repeated: script_params
and the notebook cannot be run past that point. Remove the placeholder
and keep the real value.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PyTorch estimator cell in
Inference_Bert_with_OnnxRuntime_on_AzureML.ipynbpassesscript_paramstwice — the second time as a leftover{...}placeholder:Python rejects a repeated keyword argument at compile time, so running that cell raises
and the notebook cannot proceed past it. Note this is a compile-stage error, so
ast.parse()accepts the source and onlycompile()surfaces it — which is likely why it went unnoticed.Change
Remove the placeholder line and keep the real value. One line deleted, no other cells or metadata touched.
Verified afterwards by extracting the cell source and calling
compile(src, "<cell>", "exec"), which now succeeds.